Fix Liquid capture sorting
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradlc
added a commit
that referenced
this pull request
Mar 29, 2023
thecrypticace
added a commit
that referenced
this pull request
Mar 30, 2023
thecrypticace
added a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach doesn't uniformly change all sources in all AST nodes. This results in weird behavior where only the first or last tag may end up sorted.
Because we're somewhat relying on implementation details here (the use of
.source+.positionacross various nodes rather than the values embedded in the AST) we want to make sure all changes for all classes are applied across all traversed instances of the source text in the AST.Fixes #130 (for real this time)