Fix interop with bundled CJS dependencies #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We bundle several CJS deps but the top-level format is ESM. Unfortunately esbuild does not handle converting `__filename` and `__dirname` for us so we have to patch them after build.
|
This PR probably fixes multiple issues: |
|
@thecrypticace It would be great for this package to bundle both |
|
@ohkimur This is not possible because of our need to use top-level await to handle plugin compatibility. Prettier itself does not expose async APIs in all the necessary spots unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bundle several dependencies into the
dist/index.mjsfile. Previously, the build was CJS and everything "just worked" but now that it's ESM-only some top-level constants like__filenameand__dirnameare not defined and esbuild doesn't handle that for us :( Additionally,require.cacheisn't passed through tocreateRequire(…).cacheso we do that as well.I think in an ideal world world we'd somehow split all bundled CJS dependencies into a separate
.cjsfile to allow everything to be handled by node itself. I'm not sure what that looks like at the moment though.Fix for #198 (I hope 😅)