mark tailwindcss as a peer dependency #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin uses tailwindcss internally, but marks it only as a dev dependency rather than a peer dependency, causing errors/undefined behavior in monorepos and Yarn PNP. Correctly adding tailwind as a peer dependency allows for correct resolution to occur while still referencing the *user's* tailwind and not an internal version. Other official plugins have already corrected this: see tailwindlabs/tailwindcss-forms@8a8671b This pull request is identical to tailwindlabs/tailwindcss-line-clamp#6. Both other official plugins (forms, typography) already correctly use peer dependencies.
|
Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin uses tailwindcss internally, but marks it only as a dev dependency rather than a peer dependency, causing errors/undefined behavior in monorepos and Yarn PNP. Correctly adding tailwind as a peer dependency allows for correct resolution to occur while still referencing the user's tailwind and not an internal version.
Other official plugins have already corrected this: see tailwindlabs/tailwindcss-forms@8a8671b
This pull request is identical to tailwindlabs/tailwindcss-line-clamp#6. Both other official plugins (forms, typography) already correctly use peer dependencies.