Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typescript from list of languages #645

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

max-programming
Copy link
Contributor

@max-programming max-programming commented Oct 28, 2022

I hope this fixes #644

@max-programming
Copy link
Contributor Author

@bradlc What do you think about this?

@bradlc bradlc changed the title Comment out typescript from list of languages Remove typescript from list of languages Nov 1, 2022
@bradlc
Copy link
Contributor

bradlc commented Nov 1, 2022

I agree that it makes sense to remove this, thanks!

@bradlc bradlc merged commit 19a550d into tailwindlabs:master Nov 1, 2022
@max-programming max-programming deleted the patch-1 branch November 2, 2022 01:25
@SEQUOiA87
Copy link

SEQUOiA87 commented Jan 4, 2023

Ehhh 👀

This removes typescript from the jsLanguages constant. Are you sure about this?

I don't specifically know how this constant is used by the plugin, but the fact that:

... let's me think that this change should be reverted.

In the meantime, for anyone needing this plugin to also work in typescript files, putting this into the VS Code settings helps:

"tailwindCSS.includeLanguages": {
    "typescript": "javascript"
}

@max-programming
Copy link
Contributor Author

Oh I see that now. Sorry @SEQUOiA87 I totally forgot Angular in this case.

Maybe something can be done to detect if there's an Angular project and enable then push typescript in the array?

@max-programming
Copy link
Contributor Author

Or I guess in the meantime, we could enable typescript while an issue like this persists?

@bradlc
Copy link
Contributor

bradlc commented Jan 4, 2023

Yeah I think I'll revert this for now. Was already considering it since seeing #687 👍

bradlc added a commit that referenced this pull request Jan 4, 2023
bradlc added a commit that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intellisense should not work in .ts files
3 participants