Expand classRegex search range
#840
Conversation
| start: document.positionAt(Math.max(0, positionOffset - 1000)), | ||
| end: document.positionAt(positionOffset + 1000), | ||
| start: document.positionAt(0), | ||
| end: document.positionAt(positionOffset + 2000), |
There was a problem hiding this comment.
Thanks for this PR @bradlc, it makes the situation with #837 much better.
Do you think if it’s possible to expose 2000 as an extension option? In our codebase, we have several instances of cva() which are pretty heavy on comments, so they end up being more than 2K characters long.
I guess that if we look for cva( + ), the regexp might still not work. Or is it necessary to rewrite it? What do you reckon?
There was a problem hiding this comment.
Yeah I'm open to adding it as a config option. Can you share an example from your project that wouldn't be caught within the new range?
There was a problem hiding this comment.
The project is closed sourced, so I can’t share the snippet, sorry. You can imagine chadcn → button.tsx(https://github.com/shadcn-ui/ui/blob/3c9f7ca0e20638bf75833ef920f9b23f5d97bc71/apps/www/registry/new-york/ui/button.tsx#L7-L35) (which is 1000 chars long), but with:
- a few more variants, including
compoundVariants - extra spacing between groups of lines
- comments explaining the difference between variants
- a few more class names with selectors (
hover:,sm:,data-[some-state=some-value]:,[&>svg]:and so on)
It’s quite easy to go beyond 2K symbols with all these.
There was a problem hiding this comment.
Here is an ‘aerial view’ of a real-life cva() call with 10,724 characters in-between 😁
Fixes #832
Fixes #837
This PR expands the
classRegexsearch range so that longer matches can be found (#837). Additionally the search range now always starts at the very beginning of the document, so that patterns match as expected. An example of why this matters is a simple string pattern:'[^']*'. Consider the following document:If we start searching from the beginning the matches would be:
'', 'hello world', but if we start from the second character the only match would be:' + '