This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
When running classes through
postcss-selector-parser
(inupdateAllClasses
andupdateLastClasses
) the classes (which we have already escaped, see #91) are re-escaped, and the commas are converted back from\2c
to\,
. This PR converts them back so that commas in classes containing variants are not affected by the minifier bug.I'm not sure if setting
raws.value
is the best way to do this, so open to other suggestions! Another option I considered is to runescapeCommas
on theresult
in these functions, butresult
is a full selector (e.g..something .another div
) so this felt less "correct" to me.