Update docs for Preprocessors #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-D` flag for dev dependencies. Prevent error with `require()` in `postcss.config.js` cfr [this issue](vercel/next.js#10117)
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tailwindlabs/tailwindcss-com/GhRHqgbXZ5mo6QKXdiynCagLxqhd |
vltansky
reviewed
Dec 21, 2021
| @@ -130,10 +130,10 @@ It's included directly in the `tailwindcss` package itself, so to use it all you | |||
| // postcss.config.js | |||
| module.exports = { | |||
| plugins: [ | |||
There was a problem hiding this comment.
I think it should be object plugins: {}
|
Better late than never - thanks for that 👍 I've updated the arrays to be objects instead to conform to the new format. |
jtoar
pushed a commit
to redwoodjs/redwood
that referenced
this pull request
Jul 24, 2023
I recently setup a new RW project with Tailwind and noticed a few improvements I thought could be made First I wanted our setup to as closely as possible follow the latest instructions on https://tailwindcss.com/docs/installation/using-postcss Mainly that meant to use `@tailwind base;` etc instead of `@import ...` Unfortunately (?) I couldn't use their postcss config syntax, because they're using Next-specific syntax tailwindlabs/tailwindcss.com#870 TW PR that updated their docs vercel/next.js#10117 Next issue about the syntax with some good info in the comments, including motivation on why they use this non-standard syntax Secondly I got syntax warnings in my css files after setting up Tailwind. After some googling I fixed that by installing the VS Code Tailwind intellisense extension. Looking at our code I then realized we do add that extension to the list of recommended extensions in the user's project. But we never actually tell the user to install it. I should have looked at all the files the setup command modified, but even if I had, I probably wouldn't have realized that was one of the plugins that we recommend, because the plugin ID doesn't match the name of the plugin (the ID is `bradlc.vscode-tailwindcss`) This is the first warning I spotted (`Unknown at rule @tailwind css(unknownAtRules)`)  This is what it looks like when running the setup command after my changes:  --- @jtoar * I selected the v6 milestone, but this totally doesn't have to go out in an RC. It can wait for v6.1 or whatever. It's non-breaking, but you decide when you want to release it. * For the upgrade guide we could suggest people switch to the declaration syntax instead of imports. But the imports still seem to work, so we could also just skip it.
jtoar
pushed a commit
to redwoodjs/redwood
that referenced
this pull request
Jul 26, 2023
I recently setup a new RW project with Tailwind and noticed a few improvements I thought could be made First I wanted our setup to as closely as possible follow the latest instructions on https://tailwindcss.com/docs/installation/using-postcss Mainly that meant to use `@tailwind base;` etc instead of `@import ...` Unfortunately (?) I couldn't use their postcss config syntax, because they're using Next-specific syntax tailwindlabs/tailwindcss.com#870 TW PR that updated their docs vercel/next.js#10117 Next issue about the syntax with some good info in the comments, including motivation on why they use this non-standard syntax Secondly I got syntax warnings in my css files after setting up Tailwind. After some googling I fixed that by installing the VS Code Tailwind intellisense extension. Looking at our code I then realized we do add that extension to the list of recommended extensions in the user's project. But we never actually tell the user to install it. I should have looked at all the files the setup command modified, but even if I had, I probably wouldn't have realized that was one of the plugins that we recommend, because the plugin ID doesn't match the name of the plugin (the ID is `bradlc.vscode-tailwindcss`) This is the first warning I spotted (`Unknown at rule @tailwind css(unknownAtRules)`)  This is what it looks like when running the setup command after my changes:  --- @jtoar * I selected the v6 milestone, but this totally doesn't have to go out in an RC. It can wait for v6.1 or whatever. It's non-breaking, but you decide when you want to release it. * For the upgrade guide we could suggest people switch to the declaration syntax instead of imports. But the imports still seem to work, so we could also just skip it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-Dflag for dev dependencies.Prevent error with
require()inpostcss.config.jscfr this issue