Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review API docs #290

Open
leogermani opened this issue Aug 6, 2019 · 9 comments
Open

Review API docs #290

leogermani opened this issue Aug 6, 2019 · 9 comments

Comments

@leogermani
Copy link
Contributor

Review automatic generated docs for all API endpoints.

Also add additional documentation to the website

@leogermani leogermani added the 1.0 label Aug 6, 2019
@leogermani leogermani added this to Backlog in tainacan/tainacan Aug 7, 2019
@leogermani leogermani moved this from Backlog to To Do in tainacan/tainacan Aug 22, 2019
@leogermani
Copy link
Contributor Author

Issues that have documentation on some endpoints:

#63

#69

#62

@mateuswetah
Copy link
Member

mateuswetah commented Oct 4, 2019

Regarding the Metadata endpoint, I'm putting some considerations here, that need to be checked:

  • It is related to the item_metadata, item and collection repositories, so I wasn't sure if we should merge their scheme into the array. Left it commented for now;
  • Lots of boolean attributes here are yes/no strings... shouldn't we explain this on the descriptions?
  • Some attributes does not seem to be used so far. Here are some:
  • How should I describe the metadatum_type_object inner attributes?

@mateuswetah
Copy link
Member

mateuswetah commented Oct 4, 2019

Regarding the Filters List endpoint, this needs to be checked:

  • It is related to the metadatum and collection repositories, so I wasn't sure if we should merge their scheme into the array. Left it commented for now;
  • Some attributes does not seem to be used so far. Here are some:
    • color: The color of the filter (what?);
    • max_options: The max number of options to be showed in filter sidebar. This is used, but it is extremely confusing why this is not an option.
  • How should I describe the filter_type_object inner attributes?

@mateuswetah mateuswetah moved this from To Do to In Progress in tainacan/tainacan Oct 4, 2019
@mateuswetah
Copy link
Member

mateuswetah commented Oct 4, 2019

Regarding the Taxonomies List endpoint, this needs to be checked:

  • The attribute collections_ids is described as type string when it is actually returning an array.

@mateuswetah
Copy link
Member

mateuswetah commented Oct 4, 2019

Regarding the Terms List endpoint, this needs to be checked:

  • It is related to the taxonomy repository, so I wasn't sure if we should merge this scheme into the array. Left it commented for now;
  • About the properties:
    • There is an id and a term_id, I don't think the difference is clear.
    • user: The creator of the term. I don't think it is being used. (And thats weird, isn't it the same thing as the authorid that exists in the repository?);
    • header_image: is missing. There is the header_image_id only in the schema.

@mateuswetah
Copy link
Member

mateuswetah commented Oct 4, 2019

Regarding the Logs List endpoint, this needs to be checked:

  • About the properties:
    • user_id: The description is weird (Unique identifier, the same as ID) and thats weird, isn't it the same thing as the authorid that exists in the repository?;
    • action, new_value and old_value are missing description. It would be nice to have a list of possible values here too.

@mateuswetah
Copy link
Member

Some things to mention from my latest experiments:

  • The permanently param on the DELETE of /terms is doing nothing. I believe is because we currently can't trash terms. Previously, there was a info attribute there, which also wasn't doing anything;
  • Lots of params are missing their types, I think we could work on this. Boolean values are specially contradictory, sometimes they are yes/no strings, sometime 1/0 integers...
  • I put enums on most of the situation where a list of values was the case, but I couldn't think on how to do it on the metadatumtype, as it also accepts stuff like DECIMAL(10,5)...

@mateuswetah
Copy link
Member

One more observation:

We could find out how and fix the others, because that feature seems interesting!

@vnmedeiros
Copy link
Member

reference issue:
#270

@vnmedeiros vnmedeiros added this to the v1.0 milestone Aug 13, 2021
@vnmedeiros vnmedeiros moved this from In Progress to To Do in tainacan/tainacan Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

No branches or pull requests

3 participants