Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/markdown content in collection description? #453

Closed
Ambrosiani opened this issue Nov 16, 2020 · 4 comments
Closed

html/markdown content in collection description? #453

Ambrosiani opened this issue Nov 16, 2020 · 4 comments

Comments

@Ambrosiani
Copy link
Contributor

Context and motivation

I've hardcoded a "contribute" button into the collection header but would prefer to control this from the collection settings.

Alternative solutions

Maybe let the description field have markdown support, or load it from a gutenberg block, or add another field "call to action button"

Additional context

Screenshot of existing description + hardcoded addition. Url: https://monument.kvinnohistoriska.se/kvinnans-sak/

Skärmavbild 2020-11-16 kl  09 39 58

Skärmavbild 2020-11-16 kl  09 43 59

Skärmavbild 2020-11-16 kl  09 44 30

@mateuswetah
Copy link
Member

mateuswetah commented Nov 16, 2020

Hi @Ambrosiani!

Hey, that theme looks really cool! And yes, I also find this an important issue. We've been too limited by themes implementation of the Collection description.

You should know that you can also put some HTML content on your Collection description, but this is actually a security issue and we're working to prevent it very, very soon! The same goes for Term pages. In fact we've been discussing the Markdown vs Block solution last week... it might take us a while to implement due to a large list of features that we have planned so far, but just to let clear, you can have a temporary solution:

  1. Create a page using Gutenberg blocks as you wish and use the "Faceted Items Lists" block to render your Collection;
  2. Set that page as "Cover page" of your Collection, in the Collection settings.

Obviously that is far from ideal as you would have to do for every collection that you have. Also, setting a cover page is not possible in Terms items list, but we recently opened an issue for that too (#448).

I'll keep this open so we can discuss a solution and prioritize it.

@Ambrosiani
Copy link
Contributor Author

@mateuswetah hi, thanks for the suggestions! Using a separate cover page seems like the easiest way for now – we're only dealing with one public collection at the moment.

@mateuswetah mateuswetah modified the milestone: 0.17.2 Nov 23, 2020
@mateuswetah
Copy link
Member

Marking this as related to #582!

@mateuswetah
Copy link
Member

Closing as duplicate of #582. Once we define the wysiwyg component we should be able to implement this in the collection description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants