-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new UI and refactored styles #101
Conversation
hi @vinpac Just wonder how are you going and planning to complete this PR? Would you like some help move forward? |
Maybe separate the mobile and sidebar position tasks into another PR? Otherwise I'd also like to help getting this done. |
Happy to work on the Sidebar position. But not too sure how the Sidebar position is suppose to be since the RTL support does change the position of the Sidebar. |
If you need help I'm available to contribute too 😄 |
sorry for the late reply, didn't get the notification. If we separate the mobile and sidebar position tasks into another PR it's easier for use to split up the work while also getting this thing moving. @tajo what do u think? |
I guess you can create a branch and target that for multiple PRs but it should be release altogether right? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Any chance we can have an option to move it to the left side of the screen? |
Given that this branch is quite behind now and it's hard to keep in contact @vinpac, I think the best way is to copy the work done by @vinpac to another fork branch and move forward. I'll probably start looking into this. Here's the current plan of attack I'm proposing. Each line can probably be it's own PR.
@tajo Here's a few things I need to clarify before moving ahead
I think the critical things will be the first 2 of the check list and then we can all start working in parallel. @benvds @lucasruy Still up for working on this? Shall we keep in contact on discord? |
I think it's a good setup so don't mind using those tools.
Personally I prefer the right sidebar since it makes easier to test a11y when it comes to keyboard navigation - the first focusable part of the UI is the story. Sure you can change the order and other workarounds but it just makes sense spatially. This could be also a setting so everyone can change it.
It can't be merged to the Other approach would be a feature flag but that's a risk if there is no strong commitment to actually finish it - it would just mess up the git history and codebase. |
Would love to see work done on the UI Part. Without any right to ask for features, I would do the sidebar similar to the dev-tool in browsers with a right and bottom option being the important ones and a new window being a nice to have which I probably will be doing research on myself. |
Closing for now since there's not been much activity. Feel free to re-open / continue. |
@vinpac do you have any plans to finish this? Or maybe we could've have it merged as is w/o mobile version? Looks great, and it seems like 85% of work is done |
Proposal
Rewrite styles so Ladle gets a Fresh and Professional UI that reflects its engineering powers.
Screenshots
![Example](https://user-images.githubusercontent.com/9030018/163634369-d0416596-883b-44de-89f9-19fc78fe47b0.gif)
Considerable Changes
icons.tsx
file exporting all of them. Here's an example:Tasks