Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL]: New layout #82

Closed
4 of 8 tasks
vinpac opened this issue Mar 27, 2022 · 6 comments
Closed
4 of 8 tasks

[PROPOSAL]: New layout #82

vinpac opened this issue Mar 27, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@vinpac
Copy link

vinpac commented Mar 27, 2022

Hey 👋

I love Ladle already. Its focus on performance is something I always wanted to see in Storybook. So, I wanna help it give a step forward to have a UI that matches its awesome engineering layers.

Here's is the design I made:

Light
Light

Dark
Dark

Here are the steps I imagined for this project:

  • Design the new UI
  • Collect feedbacks
  • Implement changes on the design after feedback
  • Start PR with the new layout
  • Finish first version of PR
  • Get the PR Reviewed
  • Implement requested changes
  • Get the PR merged

If this layout is not what you expect, please, feel free to express your feelings.
Thanks for the attetion.

UPDATE
The PR is now open #101 as a draft

@wojtekmaj
Copy link
Contributor

I think I've seen this somewhere 😂 Love it!

@nihgwu
Copy link

nihgwu commented Mar 28, 2022

Love it, can we add a place for brand, and layout for mobile/tablet

@vinpac
Copy link
Author

vinpac commented Mar 28, 2022

Seeing @wojtekmaj, I think Ladle deserves a more original look. It's not much, but I did a little tweak. Here's my take on mobile view too:

  • I'm doing it all grey so I make sure the contrast is good for colorblindness. My plan is to make it easy to control colors. Probably through css variables.

Light

13 Pro - 1

13 Pro - 2

@tajo tajo added the enhancement New feature or request label Mar 28, 2022
@tajo
Copy link
Owner

tajo commented Mar 28, 2022

Looks nice! I like the second version more since there is a more straightforward connection between the addon button and addon panel itself. Also, I would make the elements and text a bit bigger.

Some other notes:

  1. It would be nice if the theme could be just an alternate swappable CSS (configurable through the config). So we can have multiple options, including the current one. We can reorganize the current layout's HTML if needed.
  2. It needs to be responsive. So any theme should capture mobile, desktop, light and dark versions.

@vinpac
Copy link
Author

vinpac commented Mar 28, 2022

Sure @tajo. Thanks for the feedback. I will draft the PR implementing it

@hennessyevan
Copy link

I also like the second one with the status bar, I think that's really great.

Can we take this top-level section heading UI from storybook? Looking at the designs in this thread it seems like the intent and a popular organizational approach is to have meta sections like "atoms" "molecules", etc. Having those as folders (especially that are collapsed by default) makes it hard to locate and discover components.

image

@tajo tajo closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants