Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(react): Migrate from the deprecated React.propTypes to prop-types package #144

Merged
merged 3 commits into from
Apr 25, 2017

Conversation

gucheen
Copy link
Contributor

@gucheen gucheen commented Apr 10, 2017

Migrate from the deprecated React.propTypes to prop-types package

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

package.json Outdated
@@ -58,6 +58,7 @@
"jsdom": "^9.0.0",
"mocha": "^2.3.4",
"mocha-eslint": "^2.0.2",
"prop-types": "^15.5.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be a dependency, not a dev dependency.

@gucheen
Copy link
Contributor Author

gucheen commented Apr 25, 2017

@ljharb It has been changed. Thanks for the suggestions.

@tajo tajo merged commit f8a724c into tajo:master Apr 25, 2017
@tajo
Copy link
Owner

tajo commented Apr 25, 2017

Thank you!

@tajo
Copy link
Owner

tajo commented Apr 25, 2017

Published as v3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants