Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle effectively the Android NDK equivalent of Debian's multiarch in library searching #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented May 7, 2015

Don't know how to specify default path suffixes, so this won't help with
directories added to CMAKE_PREFIX_PATH later, but it's useful.

(Specifically, needed for CrystaX boost libs to be found, but useful in general, especially if the user has other libs installed to the CMAKE_INSTALL_PREFIX.)

…n library searching

Don't know how to specify default path suffixes, so this won't help with
directories added to CMAKE_PREFIX_PATH later, but it's useful.

(Specifically, needed for CrystaX boost libs to be found, but useful in general.)
@taka-no-me
Copy link
Owner

I'm agree with the idea of this change but not quite sure that modifying CMAKE_SYSTEM_LIBRARY_PATH is a right thing. Let me ponder for some time before deciding if it is Ok to handle it this way.

@abergmeier
Copy link
Contributor

@taka-no-me What are the reasons against this?

@rpavlik
Copy link
Contributor Author

rpavlik commented May 17, 2015

My impression from reading cmake docs is that is the place to put the path, since things that happen in the tool chain file are effectively "system", and thus the non system variables should be left under control of the build and user. Extending this particular variable allows find library to work without explicit additions per platform.

@JeroMiya JeroMiya deleted the libpath branch September 7, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants