Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Template literals instead of + operator for strings #14

Closed
uneco opened this issue Jan 16, 2019 · 1 comment
Closed

use Template literals instead of + operator for strings #14

uneco opened this issue Jan 16, 2019 · 1 comment

Comments

@uneco
Copy link
Contributor

uneco commented Jan 16, 2019

from:

    const emojiCustomizeUrl = 'https://' + teamName + '.slack.com/customize/emoji'

to:

    const emojiCustomizeUrl = `https://${teamName}.slack.com/customize/emoji`

😍
@takanakahiko
Copy link
Owner

@uneco Your proposal sounds good, because codes are unified to template literal by lint.

uneco added a commit to uneco/slack-emoji-meister that referenced this issue Jan 16, 2019
@uneco
fix: takanakahiko#14 use Template literals instead of + operator fo…
908feeb 
…r strings
@uneco uneco mentioned this issue Jan 16, 2019
Merged
2 tasks
takanakahiko pushed a commit that referenced this issue Jan 16, 2019
@uneco @takanakahiko
fix: #14 use Template literals instead of + operator for strings (#17)
4867704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uneco @takanakahiko