Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

mvnw doesn't escape directory in find_maven_basedir and MAVEN_PROJECTBASEDIR #31

Closed
etki opened this issue Dec 22, 2016 · 2 comments
Closed

mvnw doesn't escape directory in find_maven_basedir and MAVEN_PROJECTBASEDIR #31

etki opened this issue Dec 22, 2016 · 2 comments

Comments

@etki
Copy link

etki commented Dec 22, 2016

Hi.

I've noticed that maven wrapper doesn't use double quotes in find_maven_basedir/$MAVEN_PROJECTBASEDIR, so if current directory contains spaces, it will result in malformed computation.

I'm not sure how this project is managed (is mvnw somehow generated), so i didn't fork and send pull request
vicaya pushed a commit to vicaya/maven-wrapper that referenced this issue Jan 21, 2017
Quote paths in commands
983f296 
Fix issue takari#31
@vicaya vicaya mentioned this issue Jan 21, 2017
Merged
@mosabua mosabua closed this as completed Apr 4, 2017
@mosabua
Copy link
Member

mosabua commented Apr 4, 2017

Coming in release soon..

@mosabua
Copy link
Member

mosabua commented Apr 17, 2017

Fyi maven-wrapper:0.2.0 and and takari-maven-plugin:0.4.0 are released to Central.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mosabua @etki