Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

Use of bashisms make this script fail in minimal /bin/sh implementations like dash #39

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

rpelisse
Copy link

@ppalaga
Copy link

ppalaga commented Apr 11, 2017

Please do not merge yet. This is not covering all fixes we did.

@rpelisse
Copy link
Author

Yes, and actually I want to test the current master branch on Solaris 10, see what fails. I'll update the PR in the coming days.

@rpelisse
Copy link
Author

For the record, the missing fix @ppalaga mentioned is aa86cf...

@mosabua
Copy link
Member

mosabua commented Apr 11, 2017

Lgtm +1

@mosabua mosabua merged commit 6cb6e2c into takari:master Apr 11, 2017
@mosabua
Copy link
Member

mosabua commented Apr 11, 2017

Oops... just saw the message .. sorry. Just do another PR with the rest of changes if any come up. I will hold on the release ..

@mosabua
Copy link
Member

mosabua commented Apr 11, 2017

Also .. the fixes in that revision dont apply anymore since the script works a bit different now..

@rpelisse
Copy link
Author

@mosabua Yes, I saw that will porting the change. Here is what I am going to do before doing anymore PR. I'm going to run the current master (even before this PR was merged) on Solaris - see if it also fails. If so, i'll add this PR, and if needed I'll also add the changes mentioned above by @ppalaga .

I'll let you know what it comes out of it.

@mosabua
Copy link
Member

mosabua commented Apr 12, 2017

Great

@rpelisse
Copy link
Author

@mosabua @ppalaga OK, I've finished testing on Solaris 10 & 11 and come up with the following changes: #40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants