This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: JBEAP-8937
It was a bit painful to get to this point, so here is some clarification / explanation:
1) Current master is not "Solaris" proof (see Build #22 - if you have access to it)
So first of all, I can confirm that the master of maven-wrapper
0085e9f9....a6 is not passing on both on Solaris 10 and 11, for two different reasons.
On Solaris 11, apparently the keyword 'local' is not recognized:
Here is a snippet of the code not being recognized by the Solaris interpreter:
On Solaris 10, we are running in our now familliar substituion issue (see JBEAP-8937) - but on a different line:
Here is a snippet of the code being not recognized in Solaris 10:
wdir=$(cd "$wdir/.."; pwd)
Note:
2) Removes local and switch substitution to backtick (Build #25)
This fixed the build on Solaris 11, but Solaris 10 stil chocked on the substituion:
./mvnw: syntax error at line 182:
wdir=$' unexpected`Note: On Solaris 11, Maven fails to download some dependencies, but script fully works and does fire mvn, so, for the matter at hands, it works.
3) Adding a surrounding - useless, 'if' statement - as it appears to have work for JBEAP-8937 (See Build #35 - if you have access to it)
Again, the builds are failing, but after passing through the mvnw script, due to a failed download which has corrupted the associated maven repo.
Note that I have removed the change coming from PR39 because it's not compatible with the current state of mvnw.
@mosabua I would recommend using PMD or Checkstyle (or something similar) to check that nobody is introducing again the 'local' parameters (which is a shame, but as long as the plan is to somehow support Solaris 10 &11...)