Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'modelVersion' optional #180

Open
miere opened this issue Nov 20, 2018 · 5 comments
Open

Make 'modelVersion' optional #180

miere opened this issue Nov 20, 2018 · 5 comments

Comments

@miere
Copy link

miere commented Nov 20, 2018

For every single maven project I've been created I had to define <modelVersion>4.0.0</modelVersion>. Luckily, Maven Polyglot YAML makes it less verbose/annoying but still an inconvenient in which sometimes, when I miss to define it, I just got my project build failing.

What about making it optional and make it assume 4.0.0 as default value in case of being omitted?

@mosabua
Copy link
Member

mosabua commented Nov 20, 2018

To be honest we want to avoid magic things like that but rather have a straight conversion.

@mosabua
Copy link
Member

mosabua commented Nov 20, 2018

If at all, it would have to be consistent and the same in all dialects and work cleanly for import and export back and forth. Also we would then, in the future when new model version is used, figure out changes of default value or whatever.

@lefou
Copy link
Contributor

lefou commented Nov 20, 2018

In fact, we already have this default in the scala dialect: f765ca4.

@Tradunsky
Copy link
Contributor

All boilerplate stuff are optional in polyglot-kotlin as well as model version.

@mosabua
Copy link
Member

mosabua commented Nov 21, 2018

Fair enough .. then please send a PR that does a similar thing for the YAML and ideally all other dialects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants