New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get GHA working on master #233
Comments
Maybe instead of an own branch simply deactivate the module in maven (for now)? |
Sure, I can do that. |
Ok, the GHA CI is working now. Right now it's using Java11 to build, is this an issue for anyone? I'll wait until the morning to cut a release to see if anyone wants me to set this to Java8 for any reason. @headius is Java11 an issue for JRuby? |
I think Java 11 is ok for JRuby .. but not sure if everything will build on the jruby module .. Scala has been fine |
Scala Dialect is ready, see #234 |
JRuby still supports Java 8 for at least the next major version, so whatever happens we'd like to see the polyglot plugins support Java 8 a bit longer. Building with 11 would be fine if the artifacts produced are effectively |
@lefou Can the Scala module build with Java8? If there are no Java11 specific features needed I'll just build with Java8 for this release. After this release we can coordinate a release where we build with Java11. |
@jvanzyl Of course, it can. CI is already building with Java 8 and Java 11. Do you plan to automate the release via GHA, too? |
Ok, I'll do the release using Java8. I'll add some release actions for the next release. I have code now to do all the PGP signing actions in Java, but I need want to generate a sub-key, store that key as a PEM resource in GitHub secrets and then use that for the signing. |
Build is working, 0.4.7 release made. |
I tried this for the first time, and it appears that the scala module is having issues.
@mosabua is the scala module been having issues lately?
My suggestion would be to put each of the modules that are not working on their own branch, and if anyone wants to tackle fixing them up they can.
The text was updated successfully, but these errors were encountered: