Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get GHA working on master #233

Closed
jvanzyl opened this issue Oct 12, 2021 · 11 comments
Closed

Get GHA working on master #233

jvanzyl opened this issue Oct 12, 2021 · 11 comments

Comments

@jvanzyl
Copy link
Contributor

jvanzyl commented Oct 12, 2021

I tried this for the first time, and it appears that the scala module is having issues.

@mosabua is the scala module been having issues lately?

My suggestion would be to put each of the modules that are not working on their own branch, and if anyone wants to tackle fixing them up they can.

@laeubi
Copy link
Contributor

laeubi commented Oct 12, 2021

Maybe instead of an own branch simply deactivate the module in maven (for now)?

@jvanzyl
Copy link
Contributor Author

jvanzyl commented Oct 12, 2021

Sure, I can do that.

@jvanzyl
Copy link
Contributor Author

jvanzyl commented Oct 12, 2021

Ok, the GHA CI is working now. Right now it's using Java11 to build, is this an issue for anyone? I'll wait until the morning to cut a release to see if anyone wants me to set this to Java8 for any reason.

@headius is Java11 an issue for JRuby?

@mosabua
Copy link
Member

mosabua commented Oct 12, 2021

I think Java 11 is ok for JRuby .. but not sure if everything will build on the jruby module ..

Scala has been fine

@jvanzyl
Copy link
Contributor Author

jvanzyl commented Oct 12, 2021

I'll let @headius comment on JRuby, and @lefou can take what time he needs if he can get the scala module working.

@lefou
Copy link
Contributor

lefou commented Oct 13, 2021

Scala Dialect is ready, see #234

@headius
Copy link
Contributor

headius commented Oct 13, 2021

JRuby still supports Java 8 for at least the next major version, so whatever happens we'd like to see the polyglot plugins support Java 8 a bit longer. Building with 11 would be fine if the artifacts produced are effectively -release 8.

@jvanzyl
Copy link
Contributor Author

jvanzyl commented Oct 19, 2021

@lefou Can the Scala module build with Java8? If there are no Java11 specific features needed I'll just build with Java8 for this release. After this release we can coordinate a release where we build with Java11.

@lefou
Copy link
Contributor

lefou commented Oct 19, 2021

@jvanzyl Of course, it can. CI is already building with Java 8 and Java 11.

Do you plan to automate the release via GHA, too?

@jvanzyl
Copy link
Contributor Author

jvanzyl commented Oct 20, 2021

Ok, I'll do the release using Java8. I'll add some release actions for the next release. I have code now to do all the PGP signing actions in Java, but I need want to generate a sub-key, store that key as a PEM resource in GitHub secrets and then use that for the signing.

@jvanzyl
Copy link
Contributor Author

jvanzyl commented Oct 20, 2021

Build is working, 0.4.7 release made.

@jvanzyl jvanzyl closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants