Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCategories - add tiers entered by user to the default tiers list #28

Merged
merged 6 commits into from
Dec 17, 2018

Conversation

jenjenp
Copy link
Contributor

@jenjenp jenjenp commented Dec 13, 2018

No description provided.

@jenjenp jenjenp requested a review from chook December 13, 2018 06:34
@chook
Copy link
Contributor

chook commented Dec 13, 2018

@jenjenp notes for future
branch names should still be "feature/XXX" and use - and not _


if (!CollectionUtil.safeIsEmpty(namespaceToLabel)) {
Categories newCategories = Categories.from(namespaceToLabel);
categories.categories.addAll(0, newCategories.categories);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actively changes the default instance for everyone

@dor-levi dor-levi self-assigned this Dec 17, 2018
@dor-levi dor-levi merged commit c4e8082 into master Dec 17, 2018
@dor-levi dor-levi deleted the infra_routing_import_tiers branch December 17, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants