Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with python2 and pytest 3.9.2 #23

Closed
timokau opened this issue Oct 30, 2018 · 3 comments
Closed

Test failure with python2 and pytest 3.9.2 #23

timokau opened this issue Oct 30, 2018 · 3 comments

Comments

@timokau
Copy link

timokau commented Oct 30, 2018

The test_bad test fails because apparently the pytest upgrade added some warning (didn't happen with older pytest versions, doesn't happen with python3):

=================================== FAILURES ===================================
___________________________________ test_bad ___________________________________

    def test_bad():
        bad_path = [osp.join(samples_dir, 'packages3')]

        with warnings.catch_warnings(record=True) as w:
            group = entrypoints.get_group_named('entrypoints.test1', bad_path)

        assert 'bad' not in group
>       assert len(w) == 1
E       assert 2 == 1
E        +  where 2 = len([<warnings.WarningMessage object at 0x7ffff17852d0>, <warnings.WarningMessage object at 0x7ffff1766f10>])

tests/test_entrypoints.py:70: AssertionError
@onovy
Copy link

onovy commented Jan 7, 2019

these patches:
Put files to read into lists
Make regexp string raw

(already in master) fixies this.

@takluyver
Copy link
Owner

Thanks, just released 0.3, so hopefully this is fixed now.

@timokau
Copy link
Author

timokau commented Jan 7, 2019

Yes I can confirm that it is fixed. Thanks!

@timokau timokau closed this as completed Jan 7, 2019
timokau added a commit to timokau/nixpkgs that referenced this issue Jan 7, 2019
The upstream issue requiring one test to be disabled was fixed:
takluyver/entrypoints#23
dotlambda pushed a commit to NixOS/nixpkgs that referenced this issue Feb 14, 2019
The upstream issue requiring one test to be disabled was fixed:
takluyver/entrypoints#23
FRidh pushed a commit to NixOS/nixpkgs that referenced this issue Feb 16, 2019
The upstream issue requiring one test to be disabled was fixed:
takluyver/entrypoints#23
FRidh pushed a commit to NixOS/nixpkgs that referenced this issue Feb 17, 2019
The upstream issue requiring one test to be disabled was fixed:
takluyver/entrypoints#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants