Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filename in flit --help output #240

Merged
merged 2 commits into from Dec 17, 2018
Merged

Conversation

@wimglenn
Copy link
Contributor

wimglenn commented Dec 17, 2018

It's still listing flit.ini but that's not what's generated anymore.

@wimglenn wimglenn changed the title Correct generated filename in flit --help output Update filename in flit --help output Dec 17, 2018
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Dec 17, 2018

Thanks, but can we lose the test? This wouldn't have caught the problem, because the test would have been out of date too, and testing a human-readable message just means it's slightly more effort whenever you update that message.

@takluyver takluyver merged commit 0386b2b into takluyver:master Dec 17, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing fbd7a0d...924e42b
Details
codecov/project 84.64% remains the same compared to fbd7a0d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Owner

takluyver commented Dec 17, 2018

Thanks!

@wimglenn wimglenn deleted the wimglenn:flit_help branch Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.