New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add winmain.h to fix build #15

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@humem

humem commented Apr 23, 2015

winmain.h is taken from the latest crfpp version 0.59 archive stored in googlecode

@arne-cl

This comment has been minimized.

arne-cl commented Jul 11, 2015

Without the patch, compilation doesn't work.

$ /opt/crfpp# make
make  all-am
make[1]: Entering directory `/opt/crfpp'
g++ -DHAVE_CONFIG_H -I.     -O3 -Wall -c -o crf_learn.o crf_learn.cpp
crf_learn.cpp:9:21: fatal error: winmain.h: No such file or directory
 #include "winmain.h"
                     ^
compilation terminated.
make[1]: *** [crf_learn.o] Error 1
make[1]: Leaving directory `/opt/crfpp'
make: *** [all] Error 2

@tavianator tavianator referenced this pull request Oct 26, 2015

Closed

make failed #18

@Zintinio

This comment has been minimized.

Zintinio commented Apr 14, 2016

Worked around this on OS X by adding a

#ifdef _WIN32
#include "winmain.h"
#endif
@icoxfog417

This comment has been minimized.

icoxfog417 commented Nov 27, 2017

Thank you for the fix. It works for me. I'm waiting this is merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment