tests: Fix at_height may panic
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocynicys
force-pushed
the
fix-blockchain_atheight_panic
branch
from
9e188c1
to
25743b2
Compare
mariocynicys
added
tests
sr-gi
approved these changes
Sep 16, 2022
|
Needs rebase. |
`with_height` test method might produce invalid blocks because, after talaia-labs#79, we can't create empty blocks any more, and some random txs might result in a not enough proof of work as in talaia-labs#56
mariocynicys
force-pushed
the
fix-blockchain_atheight_panic
branch
from
25743b2
to
388c643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_heighttest method might produce invalid blocks because, after #79, we can't create empty blocks any more, and some random txs might result in a not enough proof of work, thus makingat_height(in #56) method panic when validating the produced blocks.Fixes #56