Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements regarding Strings in cln-plugin #135

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Minor improvements regarding Strings in cln-plugin #135

merged 2 commits into from
Dec 11, 2022

Conversation

sr-gi
Copy link
Member

@sr-gi sr-gi commented Oct 24, 2022

Some Strings could be replaced by &str and some calls made more explicit.

@sr-gi sr-gi added Seeking Code Review review me pls cln-plugin Stuff related to watchtower-plugin easy to review easypeasy labels Oct 29, 2022
@sr-gi sr-gi added this to the 0.2 milestone Nov 7, 2022
@mariocynicys mariocynicys self-requested a review December 3, 2022 19:19
@mariocynicys mariocynicys self-assigned this Dec 3, 2022
@sr-gi sr-gi merged commit d811760 into talaia-labs:master Dec 11, 2022
@sr-gi sr-gi removed the Seeking Code Review review me pls label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys Awaiting requested review from mariocynicys

Assignees

@mariocynicys mariocynicys

Labels
cln-plugin Stuff related to watchtower-plugin easy to review easypeasy
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sr-gi @mariocynicys