-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Play and Delete buttons are disabled when there aren’t any characters to play/delete
@@ -144,12 +144,12 @@ Item { | |||
Button { | |||
text: qsTr("New"); | |||
onClicked: window.state = "createCharacter"; | |||
enabled: characterList.count < accountClient.maxCharacters && !characterChosen | |||
enabled: characterList.count < accountClient.maxCharacters && characterList.count > 0 && !characterChosen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very strange. You require at least one character to be present, before you allow the creation of a new character. This means you can't create your first character. Fortunately though, I once inserted some logic that made it automatically go to the new character page when you still have done, if I remember correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong. This would disable the New button if no character is there, right?
EDIT: @bjorn was faster...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "New" Button is enabled, only Play /Delete aren't - If you open the game w/o one character the creation screen pops up, but if you create one, leave the game, delete it, you can delete/play without a character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, your right, had some problems with git so in the commit it's the wrong line..
not disabling „New“ now..
Pushed as 5ccd84a. Thanks! |
Heh, I was about to push it as well after rebasing / squashing. But your version has a better commit message. :-) |
I had a short chat with him via jabber. He is still struggeling with On 23/11/14 14:24, Thorbjørn Lindeijer wrote:
|
Play and Delete buttons are disabled when there aren’t any characters
to play/delete.