Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

Play/Delete disabled - Fixes #17 #25

Closed
wants to merge 2 commits into from

Conversation

Schaefers
Copy link

Play and Delete buttons are disabled when there aren’t any characters
to play/delete.

Play and Delete buttons are disabled when there aren’t any characters
to play/delete
@@ -144,12 +144,12 @@ Item {
Button {
text: qsTr("New");
onClicked: window.state = "createCharacter";
enabled: characterList.count < accountClient.maxCharacters && !characterChosen
enabled: characterList.count < accountClient.maxCharacters && characterList.count > 0 && !characterChosen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very strange. You require at least one character to be present, before you allow the creation of a new character. This means you can't create your first character. Fortunately though, I once inserted some logic that made it automatically go to the new character page when you still have done, if I remember correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. This would disable the New button if no character is there, right?

EDIT: @bjorn was faster...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "New" Button is enabled, only Play /Delete aren't - If you open the game w/o one character the creation screen pops up, but if you create one, leave the game, delete it, you can delete/play without a character.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, your right, had some problems with git so in the commit it's the wrong line..

not disabling „New“ now..
@Ablu
Copy link
Member

Ablu commented Nov 23, 2014

Pushed as 5ccd84a. Thanks!

@Ablu Ablu closed this Nov 23, 2014
@bjorn
Copy link
Member

bjorn commented Nov 23, 2014

Heh, I was about to push it as well after rebasing / squashing. But your version has a better commit message. :-)

@Ablu
Copy link
Member

Ablu commented Nov 23, 2014

I had a short chat with him via jabber. He is still struggeling with
getting IRC set up :)

On 23/11/14 14:24, Thorbjørn Lindeijer wrote:

Heh, I was about to push it as well after rebasing / squashing. But your
version has a better commit message. :-)


Reply to this email directly or view it on GitHub
#25 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants