Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preserve request path option #155

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add preserve request path option #155

wants to merge 3 commits into from

Conversation

jimmybot
Copy link
Contributor 

Add an option :preserve_request_path

reverse_proxy_plug currently maps url paths so that the original directory at
which the route is mounted is not passed over to the destination server

This new option preserve_request_path allows for the original directory to be
passed back so that the destination server receives the full original request
path

For example, if the option is set to true and ReverseProxyPlug were mounted at
a route '/abc' and a request came in as '/abc/123', the destination server
would be requested '/abc/123' and not '/123'

@jimmybot
fix: how host is being read and set from Plug.Conn
24ab08c 
Plug.Conn has a special key host that is used to store host information instead
of relying on the list of headers. In newer versions of Plug.Conn, it raises an
error if put_req_header is used to set host to prevent this mistake.

Read host from the right place and update tests.
@jimmybot
Update packages now that Plug.Conn.host is used properly. Req Elixir …
a57749e 
…1.10

Fix credo issue: Enum.map |> Enum.join now Enum.map_join
@jimmybot
Add an option :preserve_request_path
832c334 
reverse_proxy_plug currently maps url paths so that the original directory at
which the route is mounted is not passed over to the destination server

This new option preserve_request_path allows for the original directory to be
passed back so that the destination server receives the full original request
path

For example, if the option is set to true and ReverseProxyPlug were mounted at
a route '/abc' and a request came in as '/abc/123', the destination server
would be requested '/abc/123' and not '/123'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jimmybot