Performance fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 338 343 +5
=========================================
+ Hits 338 343 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roomrys
reviewed
Aug 11, 2022
roomrys
approved these changes
Aug 12, 2022
Comment on lines
144
to
146
| def __attrs_post_init__(self): | ||
| """Maintain point mappings between node and points after initialization.""" | ||
| super().__setattr__("points", self._convert_points(None, self.points)) |
There was a problem hiding this comment.
Could possibly use converters, but may be problematic since we use an instance method self._convert_points to do the conversion
Attributes can have a converter function specified, which will be called with the attribute’s passed-in value to get a new value to use.
Comment on lines
8
to
13
| @pytest.fixture | ||
| def hdf5_file(tmp_path): | ||
| """Define hdf5 fixture.""" | ||
| path = str(tmp_path / "test.h5") | ||
| with h5py.File(path, "w") as f: | ||
| f.create_dataset("ds1", data=np.array([0, 1, 2])) |
There was a problem hiding this comment.
Did we want all of our fixtures in the fixtures directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.