backports for 0.13.3 #4570
Merged
backports for 0.13.3 #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't expect to kexec on these actions, so no need to run kexec which might fail blocking those two actions. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit 030fd34)
Fixes siderolabs#4407 fixes siderolabs#4489 This PR started by enabling simple restart of the `kubelet` service via services API, but it turned out there's a problem: When kubelet restarts, CNI is already up, so there's an interface on the host with CNI node IP, the code which picks kubelet node IP finds it and tries to add it to the list of kubelet node IPs which completely breaks kubelet. Solution was easy: allow node IPs to be filtered out - e.g. we never want kubelet node IP to be from the pod CIDR. But this filtering feature is also useful in other cases, so I added that as well. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit a76f6d6)
As now Talos picks up node IPs by default, we need to make sure kubelet never picks up the VIP as the node IP. This issue doesn't show up with HA control plane nodes, as Talos releases VIP when kubelet restarts, but with single-node control plane nodes VIP stays on the node (as there's nowhere to move it to), so we need to filter the VIP out. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit 2d11b59)
Fixes siderolabs#4557 When running `reset` for a node which was already deleted from Kubernetes, we should ignore failure to cordon and proceed with other actions. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit c6a67b8)
Fixes siderolabs#4653 This fixes an issue when `etcd` get stuck in `Pre` state so that even `bootstrap` request doesn't kill it. This looks like a cluster which fails to bootstrap itself and get stuck on reboot. Even though `Watch()` aborts on cancel, channel receive will block forever as no events are delivered. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit 58892cd)
|
/approve |
Unix4ever
approved these changes
Nov 22, 2021
frezbo
approved these changes
Nov 22, 2021
|
/m --ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs backported:
This change is