JavaDoc and unit tests

src/main/java/nl/talsmasoftware/umldoclet/javadoc/ExternalLink.java

@@ -22,6 +22,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
+import java.net.URISyntaxException;
 import java.util.HashSet;
 import java.util.Optional;
 import java.util.Set;
@@ -33,6 +34,15 @@
 import static nl.talsmasoftware.umldoclet.util.UriUtils.addHttpParam;
 import static nl.talsmasoftware.umldoclet.util.UriUtils.addPathComponent;
 
+/**
+ * Processes {@code -link} and {@code -linkoffline} javadoc options
+ * and contains functionality to read a set of externally documented packages.
+ * <p>
+ * Since the {@code -link} option only has a single URI parameter,
+ * this uri must be used as both {@code docUri} and {@code packageListUri}.
+ *
+ * @author Sjoerd Talsma
+ */
 final class ExternalLink {
 
     private final Configuration config;
@@ -83,10 +93,10 @@ private URI makeAbsolute(URI uri) {
 
     private static URI createUri(String uri) {
         try {
-            return URI.create(uri);
-        } catch (IllegalArgumentException iae) {
+            return new URI(uri);
+        } catch (URISyntaxException use) {
             if (new File(uri).exists()) return new File(uri).toURI();
-            throw iae;
+            throw new IllegalArgumentException(use.getMessage(), use);
         }
     }
 

src/test/java/nl/talsmasoftware/umldoclet/javadoc/ExternalLinkTest.java

@@ -77,4 +77,9 @@ public void testNonExistingUrls() {
         assertThat(logger.countMessages(Message.WARNING_CANNOT_READ_PACKAGE_LIST::equals), is(1));
         verify(config, times(1)).destinationDirectory();
     }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testIllegalUrls() {
+        new ExternalLink(config, "https://www.google.com?\nq=query", "");
+    }
 }