-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot get random pokemon to work #6
Comments
I haven't tested on windows, which could be the reason. I'll check it out, thanks. Did you make sure that the pokesprite submodule is there? |
yes, the paths are correct, and it is especially weird behaviour since when
a pokemon name is passed it works.
i will test on linux as well...
…On Mon, Jan 8, 2024, 2:31 PM Tal ***@***.***> wrote:
I haven't tested on windows, which could be the reason. I'll check it out,
thanks. Did you make sure that the pokesprite submodule is there?
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEKFUHH2PO76DLBVR7NWZ3YNPRJTAVCNFSM6AAAAABBRKOCOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQHEYTSMRVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
tested on linux, still does not work. using in the installed version i also noticed this...
the output is (notice the ".png" at the start):
sadly my literall 0 knowledge of rust does not help getting to the bottom of this... |
Why not just clone with recursive submodules, like stated in the instructions? That should work, since there's probably an issue with nested directories. Or, there's a random newline being inserted somewhere? You said you made modifications which doesn't exactly inspire confidence, but you shouldn't need to change the path or anything.
Yeah, my guess is rust-embed is stupid or whatever. |
thank you for your quick responses, i will look into it further and come
back to the issue if i find a fix
…On Mon, Jan 8, 2024, 11:12 PM Tal ***@***.***> wrote:
Why not just clone with recursive submodules, like stated in the
instructions? That should work, since there's probably an issue with nested
directories. Or, there's a random newline being inserted somewhere? You
said you made modifications which doesn't exactly inspire confidence, but
you shouldn't need to change the path or anything.
in the installed version random works
Yeah, my guess is rust-embed is stupid or whatever.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEKFUE7Y2WN4FQ7RFD5ILLYNROL7AVCNFSM6AAAAABBRKOCOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRHAZDQNZYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Compiled and run the release build in both windows and linux. (used recursive cloning) |
That's super strange, does |
In both platforms, using both I have tried different ways to apply the |
This is a really weird bug... |
Could you make a repository with your current setup? Then I'll see if I can reproduce it, since it works fine for me. |
The tests i've been running were done with your recursively cloned repo (latest commit of course). Nothing at all changed. |
What version of rust are you using? Maybe it's that? |
the pain... Fyi my linux installation uses hyprland, maybe that messes things up ? but then again the exact same thing happens on windows. |
Then I have pretty much no idea why this is happening. I'll leave this issue open in case someone else has a similar problem, but this is probably one of the strangest bugs i've encountered. |
I just issued a pull request that fixed the bug. Tested on windows and linux. |
Merged 👍, thanks so much! |
Hello, i cloned your project while also downloading all the necessary sprites, i am able to run the program and successfully display pokemon. (Note that i can only do that by name).
The problem i specifically face has to do with random pokemon, it seems that the path is wrong when passing in "random", both from the terminal and hardcoded.
The code i am operating on has been slightly changed, however this was an issue from the get-go. This issue is raised as a means for feedback on whether the "random" functionality is actually working, so as to determine whether my filetree/configuration is broken
P.S. i am working on windows.
Thank you.
The text was updated successfully, but these errors were encountered: