Fix issue with 'window' object not defined

tameemsafi · Sep 17, 2019 · efb1ea3 · efb1ea3
1 parent 8ab693c
commit efb1ea3
Show file tree

Hide file tree

Showing 4 changed files with 117 additions and 84 deletions.
diff --git a/package.json b/package.json
@@ -35,10 +35,10 @@
     "jest": "^24.8.0",
     "lolex": "^4.1.0",
     "regenerator-runtime": "^0.13.2",
-    "webpack": "^4.35.0",
-    "webpack-bundle-analyzer": "^3.3.2",
-    "webpack-cli": "^3.3.5",
-    "webpack-merge": "^4.1.4"
+    "webpack": "^4.40.2",
+    "webpack-bundle-analyzer": "^3.5.0",
+    "webpack-cli": "^3.3.9",
+    "webpack-merge": "^4.2.2"
   },
   "dependencies": {
     "prop-types": "^15.6.2",

diff --git a/src/core/Typewriter.js b/src/core/Typewriter.js
@@ -78,7 +78,7 @@ class Typewriter {
     this.addEventToQueue(EVENT_NAMES.CHANGE_CURSOR, { cursor: this.options.cursor }, true);
     this.addEventToQueue(EVENT_NAMES.REMOVE_ALL, null, true);
 
-    if(!window.___TYPEWRITER_JS_STYLES_ADDED___ && !this.options.skipAddStyles) {
+    if(window && !window.___TYPEWRITER_JS_STYLES_ADDED___ && !this.options.skipAddStyles) {
       addStyles(STYLES);
       window.___TYPEWRITER_JS_STYLES_ADDED___ = true;
     }

diff --git a/webpack/common.config.babel.js b/webpack/common.config.babel.js
@@ -13,6 +13,7 @@ const config = {
     library: 'Typewriter',
     libraryTarget: 'umd',
     libraryExport: 'default',
+    globalObject: 'typeof self !== \'undefined\' ? self : this',
     umdNamedDefine: true,
   },