fix (filter): Pass scope object to parse getter

Pass `this` (= current scope) to parse getter. It execute expressions in scope
tamtakoe · Apr 21, 2014 · 64cfde6 · 64cfde6
1 parent 61fc089
commit 64cfde6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/filter/translate.js b/src/filter/translate.js
@@ -53,7 +53,7 @@ angular.module('pascalprecht.translate')
   return function (translationId, interpolateParams, interpolation) {
 
     if (!angular.isObject(interpolateParams)) {
-      interpolateParams = $parse(interpolateParams)();
+      interpolateParams = $parse(interpolateParams)(this);
     }
 
     return $translate.instant(translationId, interpolateParams, interpolation);

diff --git a/test/unit/filter/translate.spec.js b/test/unit/filter/translate.spec.js
@@ -20,13 +20,16 @@ describe('pascalprecht.translate', function () {
         .preferredLanguage('en');
     }));
 
-    var $filter, $q, $rootScope, $translate;
+    var $filter, $q, $rootScope, $translate, $compile;
 
-    beforeEach(inject(function (_$filter_, _$q_, _$rootScope_) {
+    beforeEach(inject(function (_$filter_, _$q_, _$rootScope_, _$compile_) {
       $filter = _$filter_;
       $q = _$q_;
       $rootScope = _$rootScope_;
       $translate = $filter('translate');
+      $compile = _$compile_;
+
+      $rootScope.foo = 'bar';
     }));
 
     it('should be a function object', function () {
@@ -80,6 +83,12 @@ describe('pascalprecht.translate', function () {
       expect(value[5]).toEqual('10');
       expect(value[6]).toEqual('55');
     });
+
+    it('should replace interpolate directive on element with given values', function () {
+      var element = $compile(angular.element('<div>{{"TRANSLATION_ID" | translate: "{value: foo}"}}</div>'))($rootScope);
+      $rootScope.$digest();
+      expect(element.html()).toEqual('Lorem Ipsum bar');
+    });
   });
 
   describe('additional interpolation', function () {