Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh attempts to stop service during packaging #40

Closed
icedream opened this issue May 25, 2024 · 1 comment
Closed

install.sh attempts to stop service during packaging #40

icedream opened this issue May 25, 2024 · 1 comment
Labels
bug Something isn't working packaging/AUR

Comments

@icedream
Copy link

Describe the bug
The installation script attempts to assume control over the systemd services it installs by trying to stop them if they are running. This is fine for systems directly calling the install script, though it introduces issues during AUR package build. It is a better idea to have this happen in post-install, and for the AUR package this does not make sense anyways until the actual package installation runs (where pacman's hooks manage the systemd services).

To Reproduce
Steps to reproduce the behavior:

  1. Build the package with a previous version of fw-fanctrl already installed and actively running
  2. Wait for the packaging process to call install script.

Expected behavior
It should copy the files and create the package successfully without touching any host services.

Error message

==> Starting package()...
creating '/home/icedream/Documents/Source/Git/aur.archlinux.org/fw-fanctrl-git/pkg/fw-fanctrl-git/usr/lib/systemd/system'
creating services
stopping [fw-fanctrl]
Failed to stop fw-fanctrl.service: Access denied
See system logs and 'systemctl status fw-fanctrl.service' for details.

This also pops up a graphical request to allow access to the host systemd.

Environment (please complete the following information):

  • OS: Arch
  • Version: commit fb4c933
  • Installation method: AUR/makepkg
@icedream icedream added bug Something isn't working packaging/AUR labels May 25, 2024
@icedream icedream changed the title [BUG] [packaging/AUR] install.sh attempts to stop service during packaging install.sh attempts to stop service during packaging May 25, 2024
leopoldhub added a commit to leopoldhub/fw-fanctrl that referenced this issue May 25, 2024
@leopoldhub
Copy link
Collaborator

Hi @icedream , how are you doing?
I have just created a PR #41 to fix this issue, could you please test if this solves your problem when you have some time?
Have a great day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packaging/AUR
Projects
None yet
Development

No branches or pull requests

2 participants