correct library name on first and last line #111
Conversation
|
should modify lib/js3-foot.el and lib/js3-head.el |
|
This is confusing. Do you generate |
|
Yes. Update the files in |
The actual library intended for use is "js3-mode.el". Adjust its first and last lines to mention that name instead of "js3.el". "js3.el" is a symlink to "js3-mode.el". Some users might try to load it using (require 'js3). Provide that feature in "js3-mode.el". The files in "lib/" are only intended to be used to generate "js3-mode.el" and it should therefore not be placed on the `load-path'. Add a new file "lib/.nosearch", which makes it less likely that "lib/" accidentally ends up there.
Beginning with Emacs v25.1 the second argument to `looking-back' is mandatory. It may be `nil' though, in which case it continues to behave as before (without the second argument).
It is a function, not a macro, and so its argument usually has to be quoted. In this case it does.
There are two options available (1) define `js3-mode-error' and its
alias `js3-mode-help' before using them, or (2) quote the function
symbol using `quote' instead of `function' (' instead of #').
We do the latter here. The result is that the byte-compiler no longer
knows that these function symbols are intended to be used as functions,
so it no longer checks whether these functions are defined, so it no
longer detects that this may not be the case, and does not complain.
That's okay. The functions are being defined, just after they are being
defined.
Also note that quoting the first symbol in a `defalias' form as a
function is never right. When `defalias' arguments are being evaluated
the alias (i.e. the function) is not defined yet, that's why we call it.
|
Okay, I have done that. I have also fixed some other issues the byte-compiler told me about. (Addressing these issues was harder than doing so should have been because the byte-compiler told me about errors in |
|
👍 |
|
Thanks for commit access, but I am not interested. I only came here to fix this issue because I noticed it as part of my work on the Emacsmirror. Please revoke commit access again. |
|
I still have commit access and have merged this now. Please remove my commit access - I don't want to do anymore but this. |
No description provided.