Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct library name on first and last line #111

Merged
merged 4 commits into from May 15, 2016
Merged

correct library name on first and last line #111

merged 4 commits into from May 15, 2016

Commits on May 2, 2016

  1. Adjust legacy kludges 

    The actual library intended for use is "js3-mode.el".  Adjust its first
and last lines to mention that name instead of "js3.el".

"js3.el" is a symlink to "js3-mode.el".  Some users might try to load it
using (require 'js3).  Provide that feature in "js3-mode.el".

The files in "lib/" are only intended to be used to generate
"js3-mode.el" and it should therefore not be placed on the
`load-path'. Add a new file "lib/.nosearch", which makes it less likely
that "lib/" accidentally ends up there.
    @tarsius
    tarsius committed May 2, 2016
    Copy the full SHA
    08b3ee5 View commit details
    Browse the repository at this point in the history

  2. Call looking-back with two arguments 

    Beginning with Emacs v25.1 the second argument to `looking-back' is
mandatory.  It may be `nil' though, in which case it continues to
behave as before (without the second argument).
    @tarsius
    tarsius committed May 2, 2016
    1
    Copy the full SHA
    e389fc2 View commit details
    Browse the repository at this point in the history

  3. Fix call to called-interactively-p 

    It is a function, not a macro, and so its argument usually has to be
quoted.  In this case it does.
    @tarsius
    tarsius committed May 2, 2016
    Copy the full SHA
    dda1151 View commit details
    Browse the repository at this point in the history

  4. Avoid a warning from the byte-compiler 

    There are two options available (1) define `js3-mode-error' and its
alias `js3-mode-help' before using them, or (2) quote the function
symbol using `quote' instead of `function' (' instead of #').

We do the latter here.  The result is that the byte-compiler no longer
knows that these function symbols are intended to be used as functions,
so it no longer checks whether these functions are defined, so it no
longer detects that this may not be the case, and does not complain.
That's okay.  The functions are being defined, just after they are being
defined.

Also note that quoting the first symbol in a `defalias' form as a
function is never right.  When `defalias' arguments are being evaluated
the alias (i.e. the function) is not defined yet, that's why we call it.
    @tarsius
    tarsius committed May 2, 2016
    Copy the full SHA
    dfb0c9d View commit details
    Browse the repository at this point in the history