Fixed role converter not converting a role mention #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tandemdude
pushed a commit
that referenced
this pull request
Jan 15, 2021
tandemdude
added a commit
that referenced
this pull request
Jan 15, 2021
* Fixed checks.has_permissions and checks._bot_has_permissions (#6) * Fixed checks.has_permissions * Remove unused import and whitespace * Add missing_args to NotEnoughArguments and fix iter method for WrappedArg * Run black * Fix `_human_only` check to not allow webhooks and webhook_only check (#23) * Fix IndexError when no command is provided. Fixes #24 * Temp fix human_only check * Fix walk_commands behaviour * Update sphinx requirement from ~=3.3.1 to ~=3.4.2 (#26) Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/3.x/CHANGES) - [Commits](sphinx-doc/sphinx@v3.3.1...v3.4.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed role converter not converting a role mention (#29) closes #28 * Update changelog and version number * Update usages of Message.reply to be Message.respond * Update changelog Co-authored-by: K.M Ahnaf Zamil <57180217+ahnaf-zamil@users.noreply.github.com> Co-authored-by: davfsa <davfsa@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yoda <64033043+YodaPY@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the role converter not converting a role mention (would raise a
ConverterFailureinstead)Checklist
noxand all the pipelines have passed.Related issues
#28