Don't restrict user model name and fix travis python3 build #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The requirement that the model be named "User" was pre-existing, I was just taking this opportunity to reinforce it. The name must be "User" currently becuase of hard coded reverse relations with the Group model. However, I can look into removing this restriction completely. If I can, then I'll pull this PR. |
tanderegg
added a commit
that referenced
this pull request
Feb 27, 2014
Don't restrict user model name and fix travis python3 build
tanderegg
pushed a commit
that referenced
this pull request
Feb 27, 2014
removing the spaceless tags as it mucks with html output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your changes seemed to work ok when testing locally. I'd just like to propose this small change to permit the custom user model to be named anything, not just "User".
Travis' python 3 build also broke due to wrong syntax with relative import. It's fixed in the other commit.
I enabled Travis CI for my local fork, so this change can be seen at https://travis-ci.org/koirikivi/django-cms/builds
Thanks!