Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra div #36

Closed
wants to merge 1 commit into from
Closed

Remove extra div #36

wants to merge 1 commit into from

Conversation

lifeiscontent
Copy link

@tanem are you guys considering removing the divs now that react 16.2.0 has fragments? If you want, I can submit an additional PR for that as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling be70e75 on lifeiscontent:master into c3a0e28 on atomic-app:master.

@tanem
Copy link
Owner

tanem commented Dec 3, 2017

Thanks for PR @lifeiscontent but I won't be merging this in because reasons: #24 (comment). I should really create a test around this as it comes up a lot.

Good point re fragments, will check that once I get the chance to look at the newer React version, but I'd still like this module to be compat. with older React too at this point.

@tanem tanem closed this Dec 3, 2017
@lifeiscontent
Copy link
Author

@tanem that's what major versions are for... E.g. Rails 5 and Rails 4 both still work, but use different versions of gems.

@tanem
Copy link
Owner

tanem commented Dec 4, 2017

@lifeiscontent sure, just haven't had time to give it much thought yet. At the moment having something working and stable that's low maintenance is the goal. Will get to it at some point though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants