fix(nodejs_base): use self.__class__.__name__ for derived classes com…

…mands
tanepiper · Jan 9, 2018 · eff22cf · eff22cf
1 parent 5ebe7cc
commit eff22cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/nodejs_base.py b/lib/nodejs_base.py
@@ -49,10 +49,12 @@ def run_command(self, command, callback=None, show_status=True,
             shell = True
             # doing exception for debugger commands to be able 
             # get PID of node.exe on Windows not cmd.exe
-            if __class__.__name__.lower().find("drun") != -1:
+            debug("NodeCommand: run_command: class name", self.__class__.__name__)
+            if self.__class__.__name__.lower().find("drun") != -1:
                 shell = False
 
         kwargs['shell'] = shell
+        debug("NodeCommand: run_command: kwargs", kwargs)
 
         thread = CommandThread(command, callback, **kwargs)
         thread.start()

diff --git a/lib/nodejs_command_thread.py b/lib/nodejs_command_thread.py
@@ -109,7 +109,7 @@ def run(self):
 
             # Per http://bugs.python.org/issue8557 shell=True is required to
             # get $PATH on Windows. Yay portable code.
-            shell = self.shell
+            debug("CommandThread: run: self.shell", self.shell)
             if self.working_dir != "":
                 os.chdir(self.working_dir)