do not detach main thread on error cases, fixes #446

tanersener · Jun 12, 2020 · 9a2e0a7 · 9a2e0a7
1 parent ce10a88
commit 9a2e0a7
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/android/app/src/main/cpp/mobileffmpeg.c b/android/app/src/main/cpp/mobileffmpeg.c
@@ -582,21 +582,18 @@ jint JNI_OnLoad(JavaVM *vm, void *reserved) {
     logMethod = (*env)->GetStaticMethodID(env, localConfigClass, "log", "(I[B)V");
     if (logMethod == NULL) {
         LOGE("OnLoad thread failed to GetStaticMethodID for %s.\n", "log");
-        (*globalVm)->DetachCurrentThread(globalVm);
         return JNI_FALSE;
     }
 
     statisticsMethod = (*env)->GetStaticMethodID(env, localConfigClass, "statistics", "(IFFJIDD)V");
     if (logMethod == NULL) {
         LOGE("OnLoad thread failed to GetStaticMethodID for %s.\n", "statistics");
-        (*globalVm)->DetachCurrentThread(globalVm);
         return JNI_FALSE;
     }
 
     stringConstructor = (*env)->GetMethodID(env, localStringClass, "<init>", "([BLjava/lang/String;)V");
     if (stringConstructor == NULL) {
         LOGE("OnLoad thread failed to GetMethodID for %s.\n", "<init>");
-        (*globalVm)->DetachCurrentThread(globalVm);
         return JNI_FALSE;
     }