Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

JNI_OnLoad should never detach its thread #446

Closed
alexcohn opened this issue Jun 9, 2020 · 2 comments
Closed

JNI_OnLoad should never detach its thread #446

alexcohn opened this issue Jun 9, 2020 · 2 comments
Assignees
@tanersener
Labels
enhancement New feature or request fixed
Projects
The Next FFmpeg Release

Comments

@alexcohn
Copy link
Contributor

alexcohn commented Jun 9, 2020

Description
In JNI_OnLoad() there are three error cases 1, 2, 3 that call DetachCurrentThread() (when some really nasty error happens).

Expected behavior
Only threads that are created from C may be detached.

Current behavior
The thread was created by JVM, so it should not be detached in JNI.

Environment

  • Platform: Android
  • Architecture: any
  • Version: v1.2
  • Source branch: master, and others
@tanersener tanersener added needs-analysis enhancement New feature or request and removed needs-analysis labels Jun 10, 2020
@tanersener tanersener added this to To do in The Next FFmpeg Release via automation Jun 12, 2020
tanersener added a commit that referenced this issue Jun 12, 2020
@tanersener
do not detach main thread on error cases, fixes #446
9a2e0a7
@tanersener
Copy link
Owner

Thanks, fixed in development.

@tanersener tanersener moved this from To do to Done in The Next FFmpeg Release Jun 12, 2020
@tanersener tanersener self-assigned this Jun 28, 2020
@tanersener
Copy link
Owner

Released in v4.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tanersener tanersener

Labels
enhancement New feature or request fixed
Projects
No open projects
The Next FFmpeg Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcohn @tanersener