Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

does --full when combined with --enable-gpl automatically add the gpl libraries #394

Closed
mgood7123 opened this issue Apr 22, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request fixed

Comments

@mgood7123
Copy link

does --full when combined with --enable-gpl automatically add the gpl libraries? for example:

./android.sh \
--enable-gpl \
--full \

or would i need to do

./android.sh \
--speed \
--enable-gpl \
--full \
--enable-rubberband \
--enable-libvidstab \
--enable-x264 \
--enable-x265 \
--enable-xvidcore \
@mgood7123 mgood7123 changed the title ./android.sh --full --enable-gpl does --full when combined with --enable-gpl automatically add the gpl libraries Apr 22, 2020
@tanersener tanersener self-assigned this Apr 22, 2020
@tanersener tanersener added the question Further information is requested label Apr 22, 2020
@tanersener
Copy link
Owner

No, --full does not enable GPL licensed libraries even if you add --enable-gpl option. You need to enable them explicitly.

This behaviour can be changed. I'll think about it.

@tanersener tanersener added enhancement New feature or request and removed enhancement New feature or request labels Apr 22, 2020
@tanersener tanersener added this to To do in The Next FFmpeg Release via automation Apr 22, 2020
@tanersener tanersener added enhancement New feature or request and removed question Further information is requested labels May 10, 2020
@tanersener
Copy link
Owner

Fixed in development.

@tanersener tanersener moved this from To do to Done in The Next FFmpeg Release May 10, 2020
@mgood7123
Copy link
Author

mgood7123 commented May 13, 2020

i just checked out and the changes didnt work (in both the master and development branch)

Macs-MacBook-Air:ffmpeg mac$ ./android.sh --speed --enable-gpl --full

Building mobile-ffmpeg library for Android

Architectures: arm-v7a-neon, arm64-v8a, x86, x86-64
Libraries: android-zlib, android-media-codec, fontconfig, freetype, fribidi, gmp, gnutls, lame, libass, libiconv, libtheora, libvorbis, libvpx, libwebp, libxml2, opencore-amr, shine, speex, wavpack, kvazaar, libilbc, opus, snappy, soxr, libaom, chromaprint, twolame, sdl, tesseract, openh264

Building arm-v7a-neon platform on API level 24

^C
Macs-MacBook-Air:ffmpeg mac$ ./android.sh --speed --enable-gpl --full --enable-rubberband --enable-libvidstab --enable-x264 --enable-x265 --enable-xvidcore 

Building mobile-ffmpeg library for Android

Architectures: arm-v7a-neon, arm64-v8a, x86, x86-64
Libraries: android-zlib, android-media-codec, fontconfig, freetype, fribidi, gmp, gnutls, lame, libass, libiconv, libtheora, libvorbis, libvpx, libwebp, libxml2, opencore-amr, shine, speex, wavpack, kvazaar, x264, xvidcore, x265, libvidstab, rubberband, libilbc, opus, snappy, soxr, libaom, chromaprint, twolame, sdl, tesseract, openh264

Building arm-v7a-neon platform on API level 24

^C
Macs-MacBook-Air:ffmpeg mac$ 

@tanersener
Copy link
Owner

taner@MERA mobile-ffmpeg % git checkout development                
Already on 'development'
Your branch is up to date with 'origin/development'.
taner@MERA mobile-ffmpeg % git pull                                
Already up to date.
Current branch development is up to date.
taner@MERA mobile-ffmpeg % git describe --tags                     
v4.3.2-23-g9df1b5263
taner@MERA mobile-ffmpeg % ./android.sh --speed --enable-gpl --full

Building mobile-ffmpeg library for Android

Architectures: arm-v7a-neon, arm64-v8a, x86, x86-64
Libraries: android-zlib, android-media-codec, fontconfig, freetype, fribidi, gmp, gnutls, lame, libass, libiconv, libtheora, libvorbis, libvpx, libwebp, libxml2, opencore-amr, shine, speex, wavpack, kvazaar, x264, xvidcore, x265, libvidstab, rubberband, libilbc, opus, snappy, soxr, libaom, chromaprint, twolame, sdl, tesseract, openh264, vo-amrwbenc

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tanersener
Copy link
Owner

Released in v4.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fixed
Projects
No open projects
Development

No branches or pull requests

2 participants