Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement error handling in remoteConfigContent function #1115

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

tangcent
Copy link
Owner

fix #1106

@tangcent tangcent added the type: bug Something isn't working label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.008%. Comparing base (f3f8aa8) to head (d283a78).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #1115       +/-   ##
===============================================
- Coverage     62.009%   62.008%   -0.001%     
  Complexity      2285      2285               
===============================================
  Files            249       249               
  Lines          12095     12100        +5     
  Branches        2983      2984        +1     
===============================================
+ Hits            7500      7503        +3     
- Misses          2998      3000        +2     
  Partials        1597      1597               
Flag Coverage Δ
unittests 62.008% <66.667%> (-0.001%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ugin/settings/helper/RemoteConfigSettingsHelper.kt 69.231% <66.667%> (-1.357%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f8aa8...d283a78. Read the comment docs.

@tangcent tangcent merged commit 6b8b0ae into master Mar 30, 2024
10 checks passed
@tangcent tangcent deleted the feature/config branch March 30, 2024 23:58
@tangcent tangcent mentioned this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] java.io.FileNotFoundException: \ (系统找不到指定的路径。)
1 participant