This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Fix potential crash in HdbConfigurationManager::add_domain (#6) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trols-hdbpp#6) Fix crash when getaddrinfo is returning several struct addrinfo The second struct addrinfo contains a field ai-canonname which is NULL. This caused a crash because some code was attempting to create a string from a null pointer. getaddrinfo man page (on Debian Buster) says the following: If hints.ai_flags includes the AI_CANONNAME flag, then the ai_canon- name field of the first of the addrinfo structures in the returned list is set to point to the official name of the host. So there is no need to look at the following addrinfo returned structures.
gscalam
approved these changes
Jan 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when getaddrinfo is returning several struct addrinfo
The second struct addrinfo contains a field ai-canonname which is NULL.
This caused a crash because some code was attempting to create a string from a null pointer.
getaddrinfo man page (on Debian Buster) says the following:
If hints.ai_flags includes the AI_CANONNAME flag, then the ai_canon-
name field of the first of the addrinfo structures in the returned
list is set to point to the official name of the host.
So there is no need to look at the following addrinfo returned structures.