Fix #541 RTL curved labels when segments end on neutral character #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mushon If you'd like to test this, you can do so here: https://precog.mapzen.com/tangrams/tangram/rtl-fix/#16.966313008924754/32.07126714677083/34.7888861289828 (toggle the language to "default" for Hebrew labels) It should be centered on the top image above. The multi-line labels are still not fixed, but we should have a different fix for that soon. |
|
Release in v0.12.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We detect if a broken up text segment ends on a neutral character. In this case we draw the characters individually (as separate glyphs) instead of clustering them. This should resolve the issue with curved labels for RTL text, but not for multi-line labels, which will require a different approach. This fixes part of the issue in #541.
Spaces:
Punctuation:
