Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login view disrupted #12

Closed
tanmayc07 opened this issue Sep 9, 2020 · 8 comments · Fixed by #20
Closed

Login view disrupted #12

tanmayc07 opened this issue Sep 9, 2020 · 8 comments · Fixed by #20
Assignees
@sahilambre @rutu363
Labels
bug Something isn't working
Projects
Mvp
Milestone
MVP Release

Comments

@tanmayc07
Copy link
Owner

login

Problem

  1. The placeholder of password input seems to be out of its place.
  2. The create account link is not connected to its view.

How to reproduce

Enter the address localhost:5000/auth/login

Fixes

  1. Check the password input attribute placeholder
  2. Add a connection to register view in href of the respective a tag for the create account link.
@tanmayc07 tanmayc07 added the bug Something isn't working label Sep 9, 2020
@tanmayc07 tanmayc07 added this to the MVP Release milestone Sep 9, 2020
@tanmayc07
Copy link
Owner Author

@sahilambre Any comments on this?

@sahilambre
Copy link
Collaborator

It's the helper text and not the placeholder

@tanmayc07
Copy link
Owner Author

Okay Can you fix this?

@sahilambre
Copy link
Collaborator

Yes I can but I just wanted to see what the helper text displays when the password is incorrect

@tanmayc07
Copy link
Owner Author

Okay

@sahilambre
Copy link
Collaborator

sahilambre commented Sep 9, 2020 •
edited
Loading

https://www.youtube.com/watch?v=In0nB0ABaUk Instead of using helper text can we do it this way? @tanmayc07
Just a suggestion

@sahilambre sahilambre self-assigned this Sep 9, 2020
@tanmayc07
Copy link
Owner Author

Yes that will also work!

@tanmayc07 tanmayc07 added this to To Do in Mvp Sep 12, 2020
rutu363 added a commit that referenced this issue Sep 12, 2020
@rutu363
🍻 Done validations #15 #12
27e8e69
@sahilambre
Copy link
Collaborator

@rutu363 create a PR

@tanmayc07 tanmayc07 moved this from To Do to In progress in Mvp Sep 14, 2020
@tanmayc07 tanmayc07 linked a pull request Sep 14, 2020 that will close this issue
Iss12 #20
Merged
Mvp automation moved this from In progress to Done Sep 14, 2020
@tanmayc07 tanmayc07 mentioned this issue Sep 14, 2020
Closed
tanmayc07 added a commit that referenced this issue Nov 1, 2020
@tanmayc07 @sahilambre @rutu363
Release 1.0 (#66)
3fdc0bc 
* Test commit for sahildev

* test commit for rutudev

* Initial test commit for tanmaydev

* Test commit

* 💩 add authentication

* 🗃️ Add scripts for /create and /list of blogs

* 🗃️ Add scripts for /update and /delete of blogs

* ➕ Add body-parser dependency

* added landing login reg pages

* 💄 Add create view

* 🚧 Add create and landing view and backend code

* 💫 Add logo

* Merge rutudev

* 🎨 Structure blog routes

* 🚚 Restructure auth routes #4

* 🚚 Restructure auth routes #4

* 🚚 Restructure auth routes #4

* 👽 Add auth middleware for every blog crud operation #6

* 🗃️ Resolve deprecation warning

* ✅ correct auth middleware

* 💄 Change in Register and login page #5

* 🗃️ Generalize database name #10

* 🐛 Login bug resolve

* 💄 Add tui editor in create view #3

* 🔧 password validate

* 💩 Add script for create blog

* 🚧 validations

* ✨ Update create blog script

* 🚧 validations

* 🍻 Done validations #15 #12

* ✨ Render Blog on seperate route

* ✨ Implement back button #18

* 📱 Login view and validations

* 🔥 Remove a temporary file

* 🐛 Fix UI bugs #18 #21

* 🐛 Fix footer in log and reg #21

* commit

* 💄 Connect landing to auth pages

* 💄 Error message styling in auth pages #28

* ✨ Add partial views for blog cards #2

* 🐛 Fix route and changed file name #30

* ✨ Add explore page

* Changes Logout #32

* ⚡ redirects

* 💩 Connect user and blog

* Connect user and blog schemas

* Iss33 (#36)

* 📝 Add cover image and badges #33

* 📝 Add steps to run locally #33

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* ♻️ Remove typo

* 🐛 Fix login and redirect page bug

* ⚡ Secret in .env

* ♻️ Remove comments and extra code #37

* 🗃️ Add author field in blogSchema

* 💄 Add author name on card #42

* ♻️  Redirect to explore after login

* ✨ Explore page patch

* ✨ Add functionality to create button

* ✅ myblogs #45

* 🔨 removes myblog test #45

* ✨ Frontend my blogs #50

* 💄 update ui for frontend myblogs #50

* ✨ Add edit and delete functionality to blogs

* 👽 Integrate mailchimp

* ⚡ adds 404 page

* ✨ Add navbar dropdown and avatar #55

* ➕ Add migrate-mongo dependency

* 📝 Update documentation

* 🐛 Patch

* ♻️ Refactor API to get latest blogs first

* 🔒 Add DB_URI in env

Co-authored-by: sahilambre <sahilws111@gmail.com>
Co-authored-by: Rutu <barve.rutu@gmail.com>
Co-authored-by: Rutu <62687761+rutu363@users.noreply.github.com>
Co-authored-by: Sahil Ambre <59484827+sahilambre@users.noreply.github.com>
tanmayc07 added a commit that referenced this issue Nov 22, 2020
@tanmayc07 @sahilambre @rutu363
🚀 Release 1.1 - Fix UI bugs and add tag feature (#70)
5c2d7ff 
* Test commit for sahildev

* test commit for rutudev

* Initial test commit for tanmaydev

* Test commit

* 💩 add authentication

* 🗃️ Add scripts for /create and /list of blogs

* 🗃️ Add scripts for /update and /delete of blogs

* ➕ Add body-parser dependency

* added landing login reg pages

* 💄 Add create view

* 🚧 Add create and landing view and backend code

* 💫 Add logo

* Merge rutudev

* 🎨 Structure blog routes

* 🚚 Restructure auth routes #4

* 🚚 Restructure auth routes #4

* 🚚 Restructure auth routes #4

* 👽 Add auth middleware for every blog crud operation #6

* 🗃️ Resolve deprecation warning

* ✅ correct auth middleware

* 💄 Change in Register and login page #5

* 🗃️ Generalize database name #10

* 🐛 Login bug resolve

* 💄 Add tui editor in create view #3

* 🔧 password validate

* 💩 Add script for create blog

* 🚧 validations

* ✨ Update create blog script

* 🚧 validations

* 🍻 Done validations #15 #12

* ✨ Render Blog on seperate route

* ✨ Implement back button #18

* 📱 Login view and validations

* 🔥 Remove a temporary file

* 🐛 Fix UI bugs #18 #21

* 🐛 Fix footer in log and reg #21

* commit

* 💄 Connect landing to auth pages

* 💄 Error message styling in auth pages #28

* ✨ Add partial views for blog cards #2

* 🐛 Fix route and changed file name #30

* ✨ Add explore page

* Changes Logout #32

* ⚡ redirects

* 💩 Connect user and blog

* Connect user and blog schemas

* Iss33 (#36)

* 📝 Add cover image and badges #33

* 📝 Add steps to run locally #33

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* ♻️ Remove typo

* 🐛 Fix login and redirect page bug

* ⚡ Secret in .env

* ♻️ Remove comments and extra code #37

* 🗃️ Add author field in blogSchema

* 💄 Add author name on card #42

* ♻️  Redirect to explore after login

* ✨ Explore page patch

* ✨ Add functionality to create button

* ✅ myblogs #45

* 🔨 removes myblog test #45

* ✨ Frontend my blogs #50

* 💄 update ui for frontend myblogs #50

* ✨ Add edit and delete functionality to blogs

* 👽 Integrate mailchimp

* ⚡ adds 404 page

* ✨ Add navbar dropdown and avatar #55

* ➕ Add migrate-mongo dependency

* 📝 Update documentation

* 🐛 Patch

* ♻️ Refactor API to get latest blogs first

* 🔒 Add DB_URI in env

* 💄 Add Date in Cards UI

* ✨ Fix footer in landing

* 💄 Render tags on explore and myblogs

* 💄 Add chips input in update and render blogs categorized by tags

* 💄 Fix UI bugs in update view

Co-authored-by: sahilambre <sahilws111@gmail.com>
Co-authored-by: Rutu <barve.rutu@gmail.com>
Co-authored-by: Rutu <62687761+rutu363@users.noreply.github.com>
Co-authored-by: Sahil Ambre <59484827+sahilambre@users.noreply.github.com>
tanmayc07 added a commit that referenced this issue Feb 9, 2021
@sahilambre @rutu363 @tanmayc07
📝 Add Snapshots in Documentation
f741484 
* Test commit for sahildev

* test commit for rutudev

* Initial test commit for tanmaydev

* Test commit

* 💩 add authentication

* 🗃️ Add scripts for /create and /list of blogs

* 🗃️ Add scripts for /update and /delete of blogs

* ➕ Add body-parser dependency

* added landing login reg pages

* 💄 Add create view

* 🚧 Add create and landing view and backend code

* 💫 Add logo

* Merge rutudev

* 🎨 Structure blog routes

* 🚚 Restructure auth routes #4

* 🚚 Restructure auth routes #4

* 🚚 Restructure auth routes #4

* 👽 Add auth middleware for every blog crud operation #6

* 🗃️ Resolve deprecation warning

* ✅ correct auth middleware

* 💄 Change in Register and login page #5

* 🗃️ Generalize database name #10

* 🐛 Login bug resolve

* 💄 Add tui editor in create view #3

* 🔧 password validate

* 💩 Add script for create blog

* 🚧 validations

* ✨ Update create blog script

* 🚧 validations

* 🍻 Done validations #15 #12

* ✨ Render Blog on seperate route

* ✨ Implement back button #18

* 📱 Login view and validations

* 🔥 Remove a temporary file

* 🐛 Fix UI bugs #18 #21

* 🐛 Fix footer in log and reg #21

* commit

* 💄 Connect landing to auth pages

* 💄 Error message styling in auth pages #28

* ✨ Add partial views for blog cards #2

* 🐛 Fix route and changed file name #30

* ✨ Add explore page

* Changes Logout #32

* ⚡ redirects

* 💩 Connect user and blog

* Connect user and blog schemas

* Iss33 (#36)

* 📝 Add cover image and badges #33

* 📝 Add steps to run locally #33

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* ♻️ Remove typo

* 🐛 Fix login and redirect page bug

* ⚡ Secret in .env

* ♻️ Remove comments and extra code #37

* 🗃️ Add author field in blogSchema

* 💄 Add author name on card #42

* ♻️  Redirect to explore after login

* ✨ Explore page patch

* ✨ Add functionality to create button

* ✅ myblogs #45

* 🔨 removes myblog test #45

* ✨ Frontend my blogs #50

* 💄 update ui for frontend myblogs #50

* ✨ Add edit and delete functionality to blogs

* 👽 Integrate mailchimp

* ⚡ adds 404 page

* ✨ Add navbar dropdown and avatar #55

* ➕ Add migrate-mongo dependency

* 📝 Update documentation

* 🐛 Patch

* ♻️ Refactor API to get latest blogs first

* 🔒 Add DB_URI in env

* 💄 Add Date in Cards UI

* ✨ Fix footer in landing

* 💄 Render tags on explore and myblogs

* 💄 Add chips input in update and render blogs categorized by tags

* 💄 Fix UI bugs in update view

* Add files via upload

Add snapshots of application

* Add files via upload

Add svg snapshots file

* Update README.md

Add snapshots

* Update README.md

update readme with application snapshots

* Update README.md

Update readme with snapshots

Co-authored-by: Rutu <barve.rutu@gmail.com>
Co-authored-by: tanmayc07 <tanmayc32@gmail.com>
Co-authored-by: Tanmay Chaudhari <48885301+tanmayc07@users.noreply.github.com>
Co-authored-by: Rutu <62687761+rutu363@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahilambre sahilambre

@rutu363 rutu363

Labels
bug Something isn't working
Projects
Mvp
  
Done
Milestone
MVP Release
Development

Successfully merging a pull request may close this issue.

Iss12 tanmayc07/Blog-App
3 participants
@tanmayc07 @sahilambre @rutu363