Changes in Register & Login page#5 #5
Comments
|
Also, the date input in the register page goes back till 2010 as you can see below
|
Will 1970-2020 do? @tanmayc07 |
|
Yes, that should be okay! |
|
Why did you add email field in the loginpage.ejs?Shouldn't it be Username? @rutu363 |
|
Yes that would be great.
…On Tue, 8 Sep 2020, 8:23 am Sahil Ambre, ***@***.***> wrote:
*Also, the date input in the register page goes back till 2010 as you can
see below*
*It needs to be increased as it is for birth date*
[image: Screenshot(27)]
<https://user-images.githubusercontent.com/48885301/92406037-a40bb900-f154-11ea-9f53-d776f2691b2c.png>
Will 1970-2020 do?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6IUEKQDQJG7DNM4NQO5SLSEWMCTANCNFSM4Q5QBXBA>
.
|
|
So I'll have to make changes in the script also? replace email with username? |
|
Login needs email because its unique
…On Tue, 8 Sep 2020, 9:22 am Sahil Ambre, ***@***.***> wrote:
*Why did you add email field in the loginpage.ejs?Shouldn't it be
Username?* @rutu363 <https://github.com/rutu363>
[image: issue5]
<https://user-images.githubusercontent.com/59484827/92431119-460ebe00-f1b4-11ea-9075-08fed599b64d.PNG>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6IUEIJFSPV4VNWI4RV443SEWTABANCNFSM4Q5QBXBA>
.
|
|
But if email is used in login then having username in registration doesn't make sense |
|
The same is with email. I choose email because most sites use it and if in
future we could add a feature of " sign in with gmail ".
…On Tue, 8 Sep 2020, 11:25 am Tanmay Chaudhari, ***@***.***> wrote:
But if email is used in login then having username in registration doesn't
make sense
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6IUENM5OZSFILYZBCZICLSEXBONANCNFSM4Q5QBXBA>
.
|
sahilambre
added a commit
that referenced
this issue
Sep 8, 2020
|
Review the PR |
tanmayc07
added a commit
that referenced
this issue
Sep 8, 2020
💄 Change in Register and login page #5
|
Merged. |
tanmayc07
added a commit
that referenced
this issue
Nov 1, 2020
* Test commit for sahildev * test commit for rutudev * Initial test commit for tanmaydev * Test commit * 💩 add authentication * 🗃️ Add scripts for /create and /list of blogs * 🗃️ Add scripts for /update and /delete of blogs * ➕ Add body-parser dependency * added landing login reg pages * 💄 Add create view * 🚧 Add create and landing view and backend code * 💫 Add logo * Merge rutudev * 🎨 Structure blog routes * 🚚 Restructure auth routes #4 * 🚚 Restructure auth routes #4 * 🚚 Restructure auth routes #4 * 👽 Add auth middleware for every blog crud operation #6 * 🗃️ Resolve deprecation warning * ✅ correct auth middleware * 💄 Change in Register and login page #5 * 🗃️ Generalize database name #10 * 🐛 Login bug resolve * 💄 Add tui editor in create view #3 * 🔧 password validate * 💩 Add script for create blog * 🚧 validations * ✨ Update create blog script * 🚧 validations * 🍻 Done validations #15 #12 * ✨ Render Blog on seperate route * ✨ Implement back button #18 * 📱 Login view and validations * 🔥 Remove a temporary file * 🐛 Fix UI bugs #18 #21 * 🐛 Fix footer in log and reg #21 * commit * 💄 Connect landing to auth pages * 💄 Error message styling in auth pages #28 * ✨ Add partial views for blog cards #2 * 🐛 Fix route and changed file name #30 * ✨ Add explore page * Changes Logout #32 * ⚡ redirects * 💩 Connect user and blog * Connect user and blog schemas * Iss33 (#36) * 📝 Add cover image and badges #33 * 📝 Add steps to run locally #33 * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * ♻️ Remove typo * 🐛 Fix login and redirect page bug * ⚡ Secret in .env * ♻️ Remove comments and extra code #37 * 🗃️ Add author field in blogSchema * 💄 Add author name on card #42 * ♻️ Redirect to explore after login * ✨ Explore page patch * ✨ Add functionality to create button * ✅ myblogs #45 * 🔨 removes myblog test #45 * ✨ Frontend my blogs #50 * 💄 update ui for frontend myblogs #50 * ✨ Add edit and delete functionality to blogs * 👽 Integrate mailchimp * ⚡ adds 404 page * ✨ Add navbar dropdown and avatar #55 * ➕ Add migrate-mongo dependency * 📝 Update documentation * 🐛 Patch * ♻️ Refactor API to get latest blogs first * 🔒 Add DB_URI in env Co-authored-by: sahilambre <sahilws111@gmail.com> Co-authored-by: Rutu <barve.rutu@gmail.com> Co-authored-by: Rutu <62687761+rutu363@users.noreply.github.com> Co-authored-by: Sahil Ambre <59484827+sahilambre@users.noreply.github.com>
tanmayc07
added a commit
that referenced
this issue
Nov 22, 2020
* Test commit for sahildev * test commit for rutudev * Initial test commit for tanmaydev * Test commit * 💩 add authentication * 🗃️ Add scripts for /create and /list of blogs * 🗃️ Add scripts for /update and /delete of blogs * ➕ Add body-parser dependency * added landing login reg pages * 💄 Add create view * 🚧 Add create and landing view and backend code * 💫 Add logo * Merge rutudev * 🎨 Structure blog routes * 🚚 Restructure auth routes #4 * 🚚 Restructure auth routes #4 * 🚚 Restructure auth routes #4 * 👽 Add auth middleware for every blog crud operation #6 * 🗃️ Resolve deprecation warning * ✅ correct auth middleware * 💄 Change in Register and login page #5 * 🗃️ Generalize database name #10 * 🐛 Login bug resolve * 💄 Add tui editor in create view #3 * 🔧 password validate * 💩 Add script for create blog * 🚧 validations * ✨ Update create blog script * 🚧 validations * 🍻 Done validations #15 #12 * ✨ Render Blog on seperate route * ✨ Implement back button #18 * 📱 Login view and validations * 🔥 Remove a temporary file * 🐛 Fix UI bugs #18 #21 * 🐛 Fix footer in log and reg #21 * commit * 💄 Connect landing to auth pages * 💄 Error message styling in auth pages #28 * ✨ Add partial views for blog cards #2 * 🐛 Fix route and changed file name #30 * ✨ Add explore page * Changes Logout #32 * ⚡ redirects * 💩 Connect user and blog * Connect user and blog schemas * Iss33 (#36) * 📝 Add cover image and badges #33 * 📝 Add steps to run locally #33 * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * ♻️ Remove typo * 🐛 Fix login and redirect page bug * ⚡ Secret in .env * ♻️ Remove comments and extra code #37 * 🗃️ Add author field in blogSchema * 💄 Add author name on card #42 * ♻️ Redirect to explore after login * ✨ Explore page patch * ✨ Add functionality to create button * ✅ myblogs #45 * 🔨 removes myblog test #45 * ✨ Frontend my blogs #50 * 💄 update ui for frontend myblogs #50 * ✨ Add edit and delete functionality to blogs * 👽 Integrate mailchimp * ⚡ adds 404 page * ✨ Add navbar dropdown and avatar #55 * ➕ Add migrate-mongo dependency * 📝 Update documentation * 🐛 Patch * ♻️ Refactor API to get latest blogs first * 🔒 Add DB_URI in env * 💄 Add Date in Cards UI * ✨ Fix footer in landing * 💄 Render tags on explore and myblogs * 💄 Add chips input in update and render blogs categorized by tags * 💄 Fix UI bugs in update view Co-authored-by: sahilambre <sahilws111@gmail.com> Co-authored-by: Rutu <barve.rutu@gmail.com> Co-authored-by: Rutu <62687761+rutu363@users.noreply.github.com> Co-authored-by: Sahil Ambre <59484827+sahilambre@users.noreply.github.com>
tanmayc07
added a commit
that referenced
this issue
Feb 9, 2021
* Test commit for sahildev * test commit for rutudev * Initial test commit for tanmaydev * Test commit * 💩 add authentication * 🗃️ Add scripts for /create and /list of blogs * 🗃️ Add scripts for /update and /delete of blogs * ➕ Add body-parser dependency * added landing login reg pages * 💄 Add create view * 🚧 Add create and landing view and backend code * 💫 Add logo * Merge rutudev * 🎨 Structure blog routes * 🚚 Restructure auth routes #4 * 🚚 Restructure auth routes #4 * 🚚 Restructure auth routes #4 * 👽 Add auth middleware for every blog crud operation #6 * 🗃️ Resolve deprecation warning * ✅ correct auth middleware * 💄 Change in Register and login page #5 * 🗃️ Generalize database name #10 * 🐛 Login bug resolve * 💄 Add tui editor in create view #3 * 🔧 password validate * 💩 Add script for create blog * 🚧 validations * ✨ Update create blog script * 🚧 validations * 🍻 Done validations #15 #12 * ✨ Render Blog on seperate route * ✨ Implement back button #18 * 📱 Login view and validations * 🔥 Remove a temporary file * 🐛 Fix UI bugs #18 #21 * 🐛 Fix footer in log and reg #21 * commit * 💄 Connect landing to auth pages * 💄 Error message styling in auth pages #28 * ✨ Add partial views for blog cards #2 * 🐛 Fix route and changed file name #30 * ✨ Add explore page * Changes Logout #32 * ⚡ redirects * 💩 Connect user and blog * Connect user and blog schemas * Iss33 (#36) * 📝 Add cover image and badges #33 * 📝 Add steps to run locally #33 * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * ♻️ Remove typo * 🐛 Fix login and redirect page bug * ⚡ Secret in .env * ♻️ Remove comments and extra code #37 * 🗃️ Add author field in blogSchema * 💄 Add author name on card #42 * ♻️ Redirect to explore after login * ✨ Explore page patch * ✨ Add functionality to create button * ✅ myblogs #45 * 🔨 removes myblog test #45 * ✨ Frontend my blogs #50 * 💄 update ui for frontend myblogs #50 * ✨ Add edit and delete functionality to blogs * 👽 Integrate mailchimp * ⚡ adds 404 page * ✨ Add navbar dropdown and avatar #55 * ➕ Add migrate-mongo dependency * 📝 Update documentation * 🐛 Patch * ♻️ Refactor API to get latest blogs first * 🔒 Add DB_URI in env * 💄 Add Date in Cards UI * ✨ Fix footer in landing * 💄 Render tags on explore and myblogs * 💄 Add chips input in update and render blogs categorized by tags * 💄 Fix UI bugs in update view * Add files via upload Add snapshots of application * Add files via upload Add svg snapshots file * Update README.md Add snapshots * Update README.md update readme with application snapshots * Update README.md Update readme with snapshots Co-authored-by: Rutu <barve.rutu@gmail.com> Co-authored-by: tanmayc07 <tanmayc32@gmail.com> Co-authored-by: Tanmay Chaudhari <48885301+tanmayc07@users.noreply.github.com> Co-authored-by: Rutu <62687761+rutu363@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Register & Login code is not accepting inputs the required changes have been made into registerpage uploaded in tanmaydev, just merge the two and delete the register page. Do the same with Login and login page
The text was updated successfully, but these errors were encountered: