Skip to content

Commit 4d3c2a8

Browse files
committed
No longer manually enable DEP at run-time
Many thanks to @0xC0000054 for pointing out that DEP in PhotoDemon.exe breaks compatibility with many legacy Photoshop 8bf plugins. (Note that PhotoDemon will still run fine under DEP on systems where it is enforced for *all* processes - but PhotoDemon itself will no longer manually activate DEP via SetProcessDEPPolicy.)
1 parent 828c922 commit 4d3c2a8

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

‎Modules/Main.bas‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,18 @@ DamnThisPCisOld:
102102
' where m_IsProgramRunning is declared.
103103
m_IsProgramRunning = True
104104

105+
'In the past, PhotoDemon would manually enable DEP in an attempt to satisfy various virus scanners.
106+
' (I never tested this empirically to see if it made a difference.)
107+
'
108+
'In 2023 I was notified that DEP breaks many legacy 3rd-party Photoshop plugins. Ideally, I would write a
109+
' separate non-DEP .exe that runs Photoshop plugins and then communicates results back to PD itself,
110+
' but at present it's much easier for me to simply disable DEP in PD itself as I have no empirical evidence
111+
' that manually enabling DEP makes any difference to end-users.
112+
113+
'CURRENTLY DISABLED PER COMMENT ABOVE:
105114
'On Win 7+, manually enable DEP. This may decrease issues with low-quality 3rd-party virus
106115
' and malware scanners, and PD works just fine with DEP enabled.
107-
OS.EnableProcessDEP
116+
'OS.EnableProcessDEP
108117

109118
'FormMain can now be loaded. (We load it first, because many initialization steps silently interact with it,
110119
' like loading menu icons or prepping toolboxes.) That said, the first step of FormMain's load process is calling

‎PhotoDemon.vbp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ Description="PhotoDemon Photo Editor"
520520
CompatibleMode="0"
521521
MajorVer=9
522522
MinorVer=1
523-
RevisionVer=207
523+
RevisionVer=209
524524
AutoIncrementVer=1
525525
ServerSupportFiles=0
526526
VersionComments="Copyright 2000-2023 Tanner Helland - photodemon.org"

0 commit comments

Comments
 (0)