Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD don't show the untranslated phrases ? #540

Closed
mizka76 opened this issue Mar 3, 2024 · 3 comments
Closed

PD don't show the untranslated phrases ? #540

mizka76 opened this issue Mar 3, 2024 · 3 comments
Labels
fixed (hopefully) i18n Localization issue (poor text translation, etc)

Comments

@mizka76
Copy link

mizka76 commented Mar 3, 2024

PD updated, french interface,

Hello ,
As you added options to export images and layers, I saw that some phrases were not translated in french interface:
PD shows nothing as "untranslated phrases" so, with the software "sublime text" I edited the xml langage file and find some untranslated phrases. PD shows also only 12 "translated phrases" . ( 12? it seems to show a bit more ) , before I could acess all the phrases (I didn't look at the french translation as often as before, ).

I send you a french file ( made with the sublime text software) with updated translation ("image to file", "layers to file" etc) -

Merci ! ( for your software and all the care to your users requests ! Have a nice day !

PD langage editor French  1
PD langage editor french 2
French.zip

@mizka76 mizka76 added i18n Localization issue (poor text translation, etc) unconfirmed labels Mar 3, 2024
tannerhelland added a commit that referenced this issue Mar 4, 2024
Relates to #540

Merci à @mizka76 pour un fichier de langue française mis à jour.
@tannerhelland
Copy link
Owner

Thank you for the updated French localization and bug report, @mizka76 ! I am very grateful for your ongoing help. Nightly builds have been updated with your latest French language file.

Unfortunately, I cannot seem to reproduce the translation tool problem locally! I have tried on several PCs but the language tool appears to find the right number of phrases:

image

Is it possible that another program was used to edit the language file at some point? I ask because if the language file was not saved in the same encoding that PhotoDemon natively uses, it might confuse the language editor... (I am struggling to think of another explanation for the strange behavior!)

Either way, I will keep playing with the Language Editor periodically to see if I can trigger the same bug. Thank you again for letting me know about this issue.

@mizka76
Copy link
Author

mizka76 commented Mar 14, 2024

hello,
I deleted PhotoDemon, and downloaded a new nightly build, the problem disappears. Now all is OK.

  • Yes (excuse me ! ) you are right, I have sometimes used the softwares "sublime text" or "visual code" to find easily a specific word I have translated, if it is not enough well done once I see where it goes in the interface,
  • here the translation ( made with photodemon this time) for the new JPEG XL and PDF import . Thanks a lot and bravo for all this !

French.zip

@tannerhelland
Copy link
Owner

Thank you, @mizka76 ! I appreciate you trying a fresh nightly build.

It should always be okay to edit PhotoDemon language files with other text editors, as long as the editor saves the file in the same format (UTF-8). If you encounter any trouble again, please let me know and I will investigate again.

Thank you also for the updated French language file. I will merge it in the next few minutes!

@tannerhelland tannerhelland added fixed (hopefully) and removed unconfirmed labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed (hopefully) i18n Localization issue (poor text translation, etc)
Projects
None yet
Development

No branches or pull requests

2 participants